Nova Console setup broken

[Andreas Scheuring]

Devstack patch [1] broke the nova console configuration. It moves the console config (vnc, spice, serial) from the nova.conf file into nova cells file when $CELLSV2_SETUP != "singleconductor". Due to that the console is not applied in nova-compute .

This causes the s390x zkvm third party CI to fail.
* nova configuration [2]
* Devstack command to start n-cpu: local 'command=/usr/local/bin/nova-compute --config-file /etc/nova/nova-cpu.conf' [3]

I'm not a cell expert, but from my point of view there are 2 solutions
* always configure console in n-cpu
* start n-cpu with the nova cells config file...

Patch [4] from Stephen will not fix the issue, as the method "configure_console_proxies" will be called multiple times for each cell, passing in the cell config file as "conf" [5].

[1] https://github.com/openstack-dev/devstack/commit/12579c3db7b28381c8ec97945aa23ee02d54d22b
[2] http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/510897/13/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/3e67649/logs/etc/nova/
[3] http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/510897/13/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/3e67649/logs/devstacklog.txt.gz
[4] https://review.openstack.org/#/c/550141/2/lib/nova
[5] https://github.com/openstack-dev/devstack/blob/12579c3db7b28381c8ec97945aa23ee02d54d22b/lib/nova#L598,L606

[melanie witt (melwitt)]

In nova, we recently migrated from the nova-consoleauth service backend to the database backend for console token authorization storage and thus the layout for running console proxies changed from global => per cell. So the console proxies need to consume the cell config to obtain vnc/spice/serial settings instead of the global nova.conf.

Patch [1] aimed to move vnc/spice/serial settings from global nova.conf => cell nova.conf for that reason *BUT* it looks like what I missed is that the nova-cpu.conf begins its life as a copy of the global nova.conf:

  https://github.com/openstack-dev/devstack/blob/master/lib/nova#L905

so that's why vnc/spice/serial settings disappeared from nova-cpu.conf unintended.

I'll come up with a fix for that.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/567298

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567298
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=65ad79409537a76aec5cdba4360094a3047a025d
Submitter: Zuul
Branch: master

commit 65ad79409537a76aec5cdba4360094a3047a025d
Author: melanie witt <email address hidden>
Date: Wed May 9 17:55:40 2018 +0000

    Configure console proxy settings for nova-cpu.conf

    Change 12579c3db7b28381c8ec97945aa23ee02d54d22b moved console-related
    settings from the global nova.conf to the per cell nova_cellN.conf
    because of a recent change in nova that moved console token
    authorizations from the nova-consoleauth service backend to the
    database backend and thus changed the deployment layout requirements
    from global console proxies to per cell console proxies.

    The change erroneously also removed console configuration settings from
    the nova-compute config file nova-cpu.conf because the nova-cpu.conf
    begins as a copy of the global nova.conf.

    This adds configuration of console proxies to the nova-cpu.conf in the
    start_nova_compute routine. The settings have also been split up to
    clarify which settings are used by the console proxy and which settings
    are used by nova-compute.

    Closes-Bug: #1770143

    Change-Id: I2a98795674183e2c05c29e15a3a3bad1a22c0891