installed pip version 1 does not meet minimum requirements

[bing lee]

Description：
[ERROR] /opt/stack/devstack/inc/python:146 Currently installed pip version 1 does not meet minimum requirements (>=6).

Reason：
The code in '/opt/stack/devstack/inc/python' line 142 to 148

 local pip_version
    pip_version=$(python -c "import pip; \
                        print(pip.__version__.strip('.')[0])")
    if (( pip_version<6 )); then
        die $LINENO "Currently installed pip version ${pip_version} does not" \
            "meet minimum requirements (>=6)."
    fi

When the pip version >10, the resule of 'pip.__version__.strip('.')[0]' is 1, then the error happen.

Fix method:

The code should be:

local pip_version
    pip_version=$(python -c "import pip; \
                        print(pip.__version__.split('.')[0])")
    if (( pip_version<6 )); then
        die $LINENO "Currently installed pip version ${pip_version} does not" \
            "meet minimum requirements (>=6)."
    fi

[Elod Illes (elod-illes)]

Affects stable/pike and stable/ocata only, the newer releases contain the fix

[Elod Illes (elod-illes)]

proposed fix:
stable/pike https://review.openstack.org/561411
stable/ocata https://review.openstack.org/561416

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561416
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=b376719fc0b1ce225a564c0d32091b53db408f6d
Submitter: Zuul
Branch: stable/ocata

commit b376719fc0b1ce225a564c0d32091b53db408f6d
Author: Clark Boylan <email address hidden>
Date: Fri Oct 20 12:14:29 2017 -0700

    Properly get pip version

    The old code was strip()ing the version string instead of split()ing the
    version string so we always got the first character of the version
    string. This worked fine as long as the pip version was single digit but
    as soon as it rolls over to '10.stuff' we will compare:

      pip version 1 (instead of 10) > 6

    Which fails bceause 1 is less than six. Instaed we really do want to
    compare 10 > 6 so use split on '.' instead.

    Closes-Bug: #1764046
    Change-Id: Ic7d0c04d7fa77774ab2d70fb9d11f182becec553
    (cherry picked from commit 065779517f9c99a80fbc39d51784c614e4ee341c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561411
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=91d6d0f932097d0436e43f34623ee484c9edecc7
Submitter: Zuul
Branch: stable/pike

commit 91d6d0f932097d0436e43f34623ee484c9edecc7
Author: Clark Boylan <email address hidden>
Date: Fri Oct 20 12:14:29 2017 -0700

    Properly get pip version

    The old code was strip()ing the version string instead of split()ing the
    version string so we always got the first character of the version
    string. This worked fine as long as the pip version was single digit but
    as soon as it rolls over to '10.stuff' we will compare:

      pip version 1 (instead of 10) > 6

    Which fails bceause 1 is less than six. Instaed we really do want to
    compare 10 > 6 so use split on '.' instead.

    Closes-Bug: #1764046
    Change-Id: Ic7d0c04d7fa77774ab2d70fb9d11f182becec553
    (cherry picked from commit 065779517f9c99a80fbc39d51784c614e4ee341c)

[Guiu (guiu)]

That also affects to stable/newton branch.

Thank you!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/562610

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/562610

[OpenStack Infra (hudson-openstack)]

Change abandoned by Paweł Suder (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/640985
Reason: Ok, got it, closing it, thank you!

[ydemiral (yasemin-demiral)]

stable/newton version is affected the bug

[ydemiral (yasemin-demiral)]

https://github.com/openstack/devstack/blob/f7d0851b6f8ca05ae1eb9477cfa641994bde7793/inc/python#L144

it is not merged

[Dr. Jens Harbott (j-harbott)]

As mentioned in the review, the stable/newton branch is EOL for over a year now, you should use a more current branch.

[Elod Illes (elod-illes)]

Hi Yasemin,

stable/newton reached it's End of Life and patches are not merged there anymore [1].
I suggest to use newer version of OpenStack / devstack. The recent stable version is stable/stein.

[1] https://releases.openstack.org/

Thanks,

Előd