ENABLE_KSM broken on stack.sh

Bug #1724690 reported by cminyard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
chandan kumar

Bug Description

In stack.sh, you have

if [[ "ENABLE_KSM" == "True" ]] ; then
    if [[ -f /sys/kernel/mm/ksm/run ]] ; then
        sudo sh -c "echo 1 > /sys/kernel/mm/ksm/run"
    fi
fi

ENABLE_KSM needs a $ in front of it to work. Also, I think the == needs to be = to be consistent with the rest of the file.

Change-ID I4c5addfd3e83b6516023b36cbaabd5169f0d5ceb added this code.

Revision history for this message
chandan kumar (chkumar246) wrote :

Feel free to propose a patch.

Revision history for this message
chandan kumar (chkumar246) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515347

Changed in devstack:
assignee: nobody → chandan kumar (chkumar246)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/515347
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=e8db8674855634dadd90adaadd4381f70c7227ed
Submitter: Zuul
Branch: master

commit e8db8674855634dadd90adaadd4381f70c7227ed
Author: Chandan Kumar <email address hidden>
Date: Thu Oct 26 15:34:05 2017 +0530

    Change ENABLE_KSM to $ENABLE_KSM

    * Since ENABLE_KSM param will be used in local.conf file
      and it's value is received in a variable and while compairing,
      the variable needs to be compared. So we need to change the
      same.

    Change-Id: Id4ed17c0642acd2313e456503cfc375ca6f61409
    Closes-Bug: #1724690

Changed in devstack:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.