stack process fails in case we use provider network

[Shachar Snapiri]

When we have the following combination of flags, the stack.sh process fails due to incomplete 'openstack' command:
Q_USE_PROVIDER_NETWORKING=True
IP_VERSION includes IPv4
SUBNETPOOL_V4_ID is set (USE_SUBNETPOOL=True) ->
    Causes fixed_range_v4 to not be defined

This happens in the creation of the public network.
We have a pool set for the public network, but we require the dfixed_range_v4 in the command, which becomes incomplete.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/505069

[Ihar Hrachyshka (ihar-hrachyshka)]

It would help if you can show what's the error you see.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/505069
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=fe4c3cfcf54f863ec10f970805528f9d3d0cc750
Submitter: Zuul
Branch: master

commit fe4c3cfcf54f863ec10f970805528f9d3d0cc750
Author: Shachar Snapiri <email address hidden>
Date: Tue Sep 19 09:52:00 2017 +0300

    Modified the subnet-range parameter to be optional

    The subnet-range parameter is only sent now if a valid value exists so
    the command will not fail

    Change-Id: I5296f5b59bc6d3d3db90a685a8678db9a156eece
    Closes-Bug: #1718111

[Shachar Snapiri (snapiri)]

Replying to Ihar Hrachyshka:
I do not have the setup at the moment, but the following command fails as the parameters are incomplete:
openstack --os-cloud devstack-admin --os-region default subnet create --project demo --ip-version 4 public --gateway 10.100.100.1 --subnet-pool 526f029f-a9a4-4294-b164-2a3ba3467ef4 --network public_network --subnet-range
The subnet-range argument is missing a value