running_in_container patch is merged breaking other services ironic nova neutron

[kesper]

https://review.openstack.org/#/c/446217/ patch is merged where check "running_in_container" return 0 in false condition, which is breaking all other services. for instance, ironic:

if ! running_in_container; then
        sudo modprobe nf_conntrack_tftp
        sudo modprobe nf_nat_tftp
    else
        die_if_module_not_loaded nf_conntrack_tftp
        die_if_module_not_loaded nf_nat_tftp
fi

The check value suppose to be 1.

The failure logs can be seen at http://logs.openstack.org/37/448137/3/check/gate-tempest-dsvm-ironic-pxe_ipmitool-postgres-ubuntu-xenial-nv/20504e7/logs/devstacklog.txt.gz#_2017-03-23_03_25_46_691

----
2017-03-23 03:25:46.686 | ++ functions:running_in_container:669 : [[ none == \n\o\n\e ]]
2017-03-23 03:25:46.687 | ++ functions:running_in_container:670 : return 0
2017-03-23 03:25:46.689 | ++ /opt/stack/new/ironic/devstack/lib/ironic:configure_iptables:1681 : die_if_module_not_loaded nf_conntrack_tftp
2017-03-23 03:25:46.691 | ++ /opt/stack/new/ironic/devstack/lib/ironic:die_if_module_not_loaded:1670 : grep -q nf_conntrack_tftp /proc/modules
2017-03-23 03:25:46.694 | ++ /opt/stack/new/ironic/devstack/lib/ironic:die_if_module_not_loaded:1671 : die 1671 'nf_conntrack_tftp kernel module is not loaded'
2017-03-23 03:25:46.696 | ++ functions-common:die:186 : local exitcode=0
2017-03-23 03:25:46.697 | [Call Trace]
2017-03-23 03:25:46.697 | ./stack.sh:1337:run_phase
2017-03-23 03:25:46.697 | /opt/stack/new/devstack/functions-common:1900:run_plugins
2017-03-23 03:25:46.697 | /opt/stack/new/devstack/functions-common:1867:source
2017-03-23 03:25:46.697 | /opt/stack/new/ironic/devstack/plugin.sh:61:prepare_baremetal_basic_ops
2017-03-23 03:25:46.697 | /opt/stack/new/ironic/devstack/lib/ironic:1933:configure_iptables
2017-03-23 03:25:46.697 | /opt/stack/new/ironic/devstack/lib/ironic:1681:die_if_module_not_loaded
2017-03-23 03:25:46.697 | /opt/stack/new/ironic/devstack/lib/ironic:1671:die
2017-03-23 03:25:46.701 | [ERROR] /opt/stack/new/ironic/devstack/lib/ironic:1671 nf_conntrack_tftp kernel module is not loaded
2017-03-23 03:25:47.704 | exit_trap: cleaning up child processes
2017-03-23 03:25:47.704 | ./stack.sh: line 493: kill: (19880) - No such process

-----

[kesper (paresh-h-sao)]

Submitted patch https://review.openstack.org/448910 for this