nova compute may fail on startup with ironic virt driver

[Vladyslav Drok]

Nowadays, we do not ensure that keystone is running prior to doing start_nova_compute. In case of ironic, it causes trouble, as ironic client cannot initialize without keystone and compute fails if the apache was being restarted at that moment. This was fixed previously on ironic side, but recently, another place was introduced in grenade: https://review.openstack.org/#/c/424730/.

The problem described here can be seen in http://logs.openstack.org/30/424730/18/check/gate-grenade-dsvm-ironic-ubuntu-xenial-nv/3bb8d4d/logs/new/screen-n-cpu.txt.gz?level=ERROR and http://logs.openstack.org/30/424730/18/check/gate-grenade-dsvm-ironic-ubuntu-xenial-nv/3bb8d4d/logs/apache/error.txt.gz - apache was restarting while ironic client tried to initialize.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427098

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vasyl Saienko (<email address hidden>) on branch: master
Review: https://review.openstack.org/427098

[Vasyl Saienko (vsaienko)]

In addition, nova-compute will not start as nova is upgraded prior to Ironic.
Until grenade allows to setup dependency between services during upgrade https://bugs.launchpad.net/grenade/+bug/1660646 we should ignore nova-compute service status on nova upgrade phase.

[John L. Villalovos (happycamp)]

Patch submitted:

https://review.openstack.org/#/c/427248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/427248
Committed: https://git.openstack.org/cgit/openstack-dev/grenade/commit/?id=99c8c9e998ea9a95845958fd6b1f8dbae9fadef1
Submitter: Jenkins
Branch: master

commit 99c8c9e998ea9a95845958fd6b1f8dbae9fadef1
Author: Vasyl Saienko <email address hidden>
Date: Tue Jan 31 17:16:36 2017 +0200

    Do not wait for nova-compute when ironic is enabled

    Ironic should be upgraded before nova according to requirements [0]
    using reverse order will lead to nova-compute start failure.
    This patch ensures that we do not check nova-compute status in the
    nova upgarde phase, when ironic is enabled, as it is expected behaviour.
    Ironic will restart nova-compute later.

    [0] http://docs.openstack.org/developer/ironic/deploy/upgrade-guide.html#general-upgrades-all-versions

    Change-Id: I48dc7649eedb6c6d6753da8ba66fcfccb09acd58
    Closes-Bug: #1660581
    Related-Bug: #1660646

[Sean Dague (sdague)]

No open reviews found in this bug, unassigning. Please add a comment with active reviews before assigning an individual, or tag the bug in the gerrit review, which will do that automatically. We try not to assign bugs without patches as that discourages other folks from looking into bugs.

[Dr. Jens Harbott (j-harbott)]

Seems that this was fixed in grenade.