stack.sh doesn't support share nova instance path

[Amy Fong]

In cases where the nova instances directory is an (nfs) shared directory and nova instances path is located somewhere under nova state path, running stack.sh for a multinode setup and for a compute node results in an error message when stack.sh tries to cleanup.

The workaround is to manually unmount the instances directory and remount after running stack.sh

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/409907

[Sean Dague (sdague)]

This devstack bug was last updated over 180 days ago, as devstack
is a fast moving project and we'd like to get the tracker down to
currently actionable bugs, this is getting marked as Invalid. If the
issue still exists, please feel free to reopen it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/476987

[Chris Friesen (cbf123)]

I've confirmed that the current code still unconditionally deletes everything in $NOVA_INSTANCES_PATH, which is a problem if you have multiple nodes all sharing a common network-mounted instance directory.

[Chris Friesen (cbf123)]

I've proposed a new patch at https://review.openstack.org/476987 that just skips the cleanup step during startup. We'll still do it in clean.sh. (Did we want to add it to unstack.sh?)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476987
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=0ffd5a944c371ae441c2c8d977486c5a20bc75fc
Submitter: Zuul
Branch: master

commit 0ffd5a944c371ae441c2c8d977486c5a20bc75fc
Author: Chris <email address hidden>
Date: Fri Jun 23 11:28:20 2017 -0600

    remove unnecessary cleanup in nova startup

    nova's instances directory may be a shared directory (ie nfs), in
    these cases, we do not want to call nova_cleanup at startup since it
    deletes everything under $NOVA_INSTANCES_PATH.

    The nova_cleanup routine will still be called by the clean.sh script
    which is fine since we're presumably cleaning up the whole openstack
    cluster at that point.

    Change-Id: Ieb4e5d0508d4ed4c5349c497554c5da2993c9cb0
    Closes-Bug: #1649389

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dr. Jens Harbott <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/devstack/+/409907
Reason: issue fixed by https://review.opendev.org/c/openstack/devstack/+/476987