post-config section order matters

Bug #1583214 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
YAMAMOTO Takashi

Bug Description

With the following local.conf, [quotas] section is not updated: http://paste.fedoraproject.org/367987/14635817/

But when I move the section to the top before all other sections, it applies fine:
http://paste.fedoraproject.org/367975/58031014/

I suspect awk code that merges config sections has some ordering issue.

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

Ihar,

pastes links just say "does not exist" for me.
can you (re?)provide them?

Changed in devstack:
status: New → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/402888

Changed in devstack:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/402888
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=02f3f9a6bbb6c4af989ad6cf504d5c49d7c9b4e2
Submitter: Jenkins
Branch: master

commit 02f3f9a6bbb6c4af989ad6cf504d5c49d7c9b4e2
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Nov 26 00:43:07 2016 +0900

    meta-config: Fix consecutive same sections

    The current coding fails to process local.conf like
    the following. Note: This example is taken from a
    real use case. [1]

        [[post-config|$NEUTRON_CONF]]
        [qos]
        notification_drivers = midonet
        [[post-config|$NEUTRON_CONF]]

        [quotas]
        # x10 of default quotas (at the time of writing)
        quota_network=100
        quota_subnet=100
        quota_port=500
        quota_router=100
        quota_floatingip=500
        quota_security_group=100
        quota_security_group_rule=1000

    [1] https://review.openstack.org/#/c/400627/

    Closes-Bug: #1583214
    Change-Id: Ie571b5fa5a33d9ed09f30ba7c7724b958ce17616

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/404018

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (stable/newton)

Reviewed: https://review.openstack.org/404018
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=85032db5139189aa15d372678f5169c3b8f4f5cd
Submitter: Jenkins
Branch: stable/newton

commit 85032db5139189aa15d372678f5169c3b8f4f5cd
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Nov 26 00:43:07 2016 +0900

    meta-config: Fix consecutive same sections

    The current coding fails to process local.conf like
    the following. Note: This example is taken from a
    real use case. [1]

        [[post-config|$NEUTRON_CONF]]
        [qos]
        notification_drivers = midonet
        [[post-config|$NEUTRON_CONF]]

        [quotas]
        # x10 of default quotas (at the time of writing)
        quota_network=100
        quota_subnet=100
        quota_port=500
        quota_router=100
        quota_floatingip=500
        quota_security_group=100
        quota_security_group_rule=1000

    [1] https://review.openstack.org/#/c/400627/

    Closes-Bug: #1583214
    Change-Id: Ie571b5fa5a33d9ed09f30ba7c7724b958ce17616
    (cherry picked from commit 02f3f9a6bbb6c4af989ad6cf504d5c49d7c9b4e2)

tags: added: in-stable-newton
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.