devstack

function "trueorfalse" in functions-common failed.

Bug #1577627 reported by Haifeng.Yan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Invalid
Undecided
Haifeng.Yan

Bug Description

$ source functions-common
$ trueorfalse False yes
False

I found that function trueorfalse has bugs:
https://github.com/openstack-dev/devstack/blob/master/functions-common#L150

. and also test in ./tests/test_truefalse.sh doesn't check as we expected:
https://github.com/openstack-dev/devstack/blob/master/tests/test_truefalse.sh#L29

so when we run ./tests/test_truefalse.sh, all test pase.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/311923

Changed in devstack:
assignee: nobody → Haifeng.Yan (yanheven)
status: New → In Progress
Sean M. Collins (scollins)
Changed in devstack:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on devstack (master)

Change abandoned by Haifeng Yan (<email address hidden>) on branch: master
Review: https://review.openstack.org/311923
Reason: my misunderstanding of trueorfalse function.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.