Clean out security group tests from tempest-dsvm-cells-rc

[Matt Riedemann]

There are several tests in http://git.openstack.org/cgit/openstack/nova/tree/devstack/tempest-dsvm-cells-rc which are skipped in devstack + tempest + cells runs because cells doesn't support security groups.

Some of these are obvious, like:

# skip security group tests
r="$r(?:tempest\.api\.compute\.security_groups.*)"

There are others, like scenario tests (test_stamp_pattern) which don't work with cells because they create a security group for the server instance being tested:

http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_stamp_pattern.py#n155

Since security group usage in nova is optional (openstack-infra doesn't use them since RAX doesn't support them - due to cells), Tempest should have a compute-feature-enabled.security_groups config option in here:

http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n315

That would default to True for backwards compatibility with Tempest.

Then in devstack/lib/tempest if we're running with cells, we can set compute-feature-enabled.security_groups=False so that jobs running tempest + devstack + cells don't run those tests.

Once we have that devstack change, we can remove the tests from tempest-dsvm-cells-rc which are only skipped because of security groups.

Note that the Tempest change which adds the compute-feature-enabled.security_groups config option will also have to go through and add skip checks for any tests that are creating and using security groups on server instances.

So the chain of changes would be:

1. Tempest
2. devstack
3. nova

The nova change would be similar to how this was done:

https://review.openstack.org/#/c/220158/

[Matt Riedemann (mriedem)]

The nova change might depend on https://review.openstack.org/#/c/197514/ if it's not merged yet - that makes keypairs work with cells which some of the tests use (like scenario tests).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/225199

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/225204

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226043

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/226043
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[chandan kumar (chkumar246)]

Changing from in-progress to confirmed as the patch is abandoned and not updated from long time.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Treinish (<email address hidden>) on branch: master
Review: https://review.openstack.org/225199
Reason: This hasn't seen an update in a year. mriedem says ccarmack won't be able to pick this up again. If someone wants to continue the work feel free to restore this patch.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/225204

[Maciej Szankin (mszankin)]

This bug report has an assignee for a while now but there is no patch
for that. It looks like that the chance of getting a patch is low.
I'm going to remove the assignee to signal to others that they can take
over if they like.
If you want to work on this, please:
* add yourself as assignee AND
* set the status to "In Progress" AND
* provide a (WIP) patch within the next 2 weeks after that.
If you need assistance, reach out on the IRC channel #openstack-nova or
use the mailing list.

Also tagging as New. It is old and requires to be verified.

[Matt Riedemann (mriedem)]

I think we can drop this, no one is working on this anymore.