duplicate 'global_filter' created by function set_lvm_filter

Bug #1437998 reported by Sam Wan
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Ian Wienand

Bug Description

function set_lvm_filter in https://github.com/openstack-dev/devstack/tree/master/lib only creates 'global_filter' but not removes existing one which causes below warnings:
WARNING: Ignoring duplicate config node: global_filter (seeking global_filter)

Fix is simple.
Just insert below line before setting 'global_filter' in set_lvm_filter to remove any existing 'global_filter':
sudo sed -ir '/^\s*global_filter.*$/d' /etc/lvm/lvm.conf

or use below line to comment out any existing global_filter by:
sudo sed -ir 's/^\s*(global_filter.*)$/#\1/g' /etc/lvm/lvm.conf

Revision history for this message
Sam Wan (sam-wan) wrote :
Changed in devstack:
assignee: nobody → Sam Wan (sam-wan)
Changed in devstack:
status: New → In Progress
Changed in devstack:
assignee: Sam Wan (sam-wan) → Ian Wienand (iwienand)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/176889
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=6cdb2e0f1a2c2429587f1e9187344cb26eb31812
Submitter: Jenkins
Branch: master

commit 6cdb2e0f1a2c2429587f1e9187344cb26eb31812
Author: Dan Smith <email address hidden>
Date: Thu Apr 23 09:12:59 2015 -0700

    Remove the lvm.conf filter during cleanup

    This avoids us leaving the filter in the global lvm config. Without cleaning
    this up, we can hit some failures to run stack.sh because devices are excluded
    that we need to be able to see. This resets it to what it was before when
    we do a cleanup.

    Also, do this before we add the line, so we don't add multiple lines on
    successive runs.

    Closes-bug: #1437998
    Change-Id: Idbf8a06b723f79ef16a7c175ee77a8c25f813244

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on devstack (master)

Change abandoned by Sam Wan (<email address hidden>) on branch: master
Review: https://review.openstack.org/176222

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/182385

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (stable/kilo)

Reviewed: https://review.openstack.org/182385
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=2d4ea363aeb059939cf0947a54acd19ac4e9d3b0
Submitter: Jenkins
Branch: stable/kilo

commit 2d4ea363aeb059939cf0947a54acd19ac4e9d3b0
Author: Dan Smith <email address hidden>
Date: Thu Apr 23 09:12:59 2015 -0700

    Remove the lvm.conf filter during cleanup

    This avoids us leaving the filter in the global lvm config. Without cleaning
    this up, we can hit some failures to run stack.sh because devices are excluded
    that we need to be able to see. This resets it to what it was before when
    we do a cleanup.

    Also, do this before we add the line, so we don't add multiple lines on
    successive runs.

    Closes-bug: #1437998
    Change-Id: Idbf8a06b723f79ef16a7c175ee77a8c25f813244
    (cherry picked from commit 6cdb2e0f1a2c2429587f1e9187344cb26eb31812)

tags: added: in-stable-kilo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.