devstack

unstack.sh will stop dstat, when dstat is disable service

Bug #1435148 reported by Mahito OGURA
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Mahito OGURA

Bug Description

unstack.sh would stop dstat process, however process didn't be found.

=====================
 ./unstack.sh
Site keystone disabled.
...
stop: Unknown instance:
dstat: no process found
=====================

I didn't set dstat at local.conf.
(I believe that default dstat is disable service.)

If dstat is disable service, unstack.sh shouldn't run stop_dstat as well as other disable services.

See original description
Mahito OGURA (earthdragon77)
Changed in devstack:
assignee: nobody → Mahito OGURA (earthdragon77)
Mahito OGURA (earthdragon77)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166709

Changed in devstack:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/166709
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=a519f429cf3cd90f06dd50b95608ec18f81d400c
Submitter: Jenkins
Branch: master

commit a519f429cf3cd90f06dd50b95608ec18f81d400c
Author: Mahito OGURA <email address hidden>
Date: Mon Mar 23 15:19:57 2015 +0900

    Fix unstack.sh to stop stop_dstat when it is disabled.

    unstack.sh always stop dstat process, however unstack.sh show 'dstat: no process
    found' when dstat is disabled.
    This patch stop function of stop_dstat, when dstat is disabled.

    Change-Id: If9054826bed8a7fedd4f77ef4efef2c0ccd7f16e
    Closes-Bug: #1435148

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/167093

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (stable/juno)

Reviewed: https://review.openstack.org/167093
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=8c601bcc5199d35bd113a0aa37d7f8ba7335cb92
Submitter: Jenkins
Branch: stable/juno

commit 8c601bcc5199d35bd113a0aa37d7f8ba7335cb92
Author: Mahito OGURA <email address hidden>
Date: Mon Mar 23 15:19:57 2015 +0900

    Fix unstack.sh to stop stop_dstat when it is disabled.

    unstack.sh always stop dstat process, however unstack.sh show 'dstat: no process
    found' when dstat is disabled.
    This patch stop function of stop_dstat, when dstat is disabled.

    Backported from https://review.openstack.org/#/c/166709/

    Change-Id: If9054826bed8a7fedd4f77ef4efef2c0ccd7f16e
    Closes-Bug: #1435148

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.