use of local.conf doesn't replace shell variables

Bug #1386413 reported by Walt Boring
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Ian Wienand

Bug Description

The recent change to lib/config has broken support in local.conf for environment variable assignment and replacement.

My team's local.conf has settings as follows

[[local|localrc]]
CINDER_BACKENDS=3parfc,3pariscsi

HP3PAR_API_URL=http://10.50.129.1:8080/api/v1

[[post-config|$CINDER_CONF]]

[DEFAULT]
enabled_backends=$CINDER_BACKENDS

[3parfc]
hp3par_api_url=${HP3PAR_API_URL}

[3pariscsi]
hp3par_api_url=${HP3PAR_API_URL}

This results in an /etc/cinder/cinder.conf

[DEFAULT]
...
enabled_backends=$CINDER_BACKENDS

[3parfc]
hp3par_api_url=${HP3PAR_API_URL}

[3pariscsi]
hp3par_api_url=${HP3PAR_API_URL}

This used to work prior to the d6aa629ce424269f2a2a46a693027a1d564f3d42 revision of lib/config

Changed in devstack:
status: New → Confirmed
Revision history for this message
Ian Wienand (iwienand) wrote :

I'm trying to decide if this is a bug or a feature -- if we eval() the lines, then we'll drop the support for embedded "'s

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131334

Changed in devstack:
assignee: nobody → Ian Wienand (iwienand)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/131334
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=f3bf8b6cc0dc94684a3bbecc4cc1e2169506f804
Submitter: Jenkins
Branch: master

commit f3bf8b6cc0dc94684a3bbecc4cc1e2169506f804
Author: Ian Wienand <email address hidden>
Date: Wed Oct 29 21:53:56 2014 +1100

    Revert "Single quote iniset argument in merge_config_file"

    This reverts commit e2c9fee8ed846aba124a2fc1bba245790ed7ba90.

    We have decided that we don't want to support the json-style argument
    as described by bug#1374118 (see thread at [1]).

    This restores the old behavior of sending the argument in
    double-quotes so environment variables get expanded. As a bonus,
    tests for this are added.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2014-October/049341.html

    Change-Id: I9fc99f3716cc53366907878adb00ae6cf3898f14
    Closes-Bug:#1386413

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/138122

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (stable/juno)

Reviewed: https://review.openstack.org/138122
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=6a7185c905356eb9a71618d491a411462ead1982
Submitter: Jenkins
Branch: stable/juno

commit 6a7185c905356eb9a71618d491a411462ead1982
Author: Ian Wienand <email address hidden>
Date: Wed Oct 29 21:53:56 2014 +1100

    Revert "Single quote iniset argument in merge_config_file"

    This reverts commit e2c9fee8ed846aba124a2fc1bba245790ed7ba90.

    We have decided that we don't want to support the json-style argument
    as described by bug#1374118 (see thread at [1]).

    This restores the old behavior of sending the argument in
    double-quotes so environment variables get expanded. As a bonus,
    tests for this are added.

    [1] http://lists.openstack.org/pipermail/openstack-dev/2014-October/049341.html

    Change-Id: I9fc99f3716cc53366907878adb00ae6cf3898f14
    Closes-Bug:#1386413
    (cherry picked from commit f3bf8b6cc0dc94684a3bbecc4cc1e2169506f804)

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers