swift fails to run when not using rsyslog

[Yves-Gwenael Bourhis]

Environment:
$ dpkg -l | grep -i syslog
ii libevtlog0 0.2.12-5 Syslog event logger library
hi syslog-ng-core 3.4.7-1~mhp1.sysvinit-cw1 Next generation system logging daemon (core)

./stach.sh fails with:

2014-04-16 10:17:06.163 | + sudo tee /etc/rsyslog.d/10-swift.conf
2014-04-16 10:17:06.164 | + sed s,%SWIFT_LOGDIR%,/opt/stack/data/swift/logs, /home/chef/devstack/files/swift/rsyslog.conf
2014-04-16 10:17:06.166 | tee: /etc/rsyslog.d/10-swift.conf: No such file or directory
2014-04-16 10:17:06.167 | # Uncomment the following to have a log containing all logs together
2014-04-16 10:17:06.169 | #local1,local2,local3,local4,local5.* /opt/stack/data/swift/logs/all.log
2014-04-16 10:17:06.170 |
2014-04-16 10:17:06.172 | # Uncomment the following to have hourly proxy logs for stats processing
2014-04-16 10:17:06.173 | #$template HourlyProxyLog,"/opt/stack/data/swift/logs/hourly/%$YEAR%%$MONTH%%$DAY%%$HOUR%"
2014-04-16 10:17:06.175 | #local1.*;local1.!notice ?HourlyProxyLog
2014-04-16 10:17:06.176 |
2014-04-16 10:17:06.178 | local1.*;local1.!notice /opt/stack/data/swift/logs/proxy.log
2014-04-16 10:17:06.179 | local1.notice /opt/stack/data/swift/logs/proxy.error
2014-04-16 10:17:06.181 | local1.* ~
2014-04-16 10:17:06.182 |
2014-04-16 10:17:06.184 | local2.*;local2.!notice /opt/stack/data/swift/logs/storage1.log
2014-04-16 10:17:06.185 | local2.notice /opt/stack/data/swift/logs/storage1.error
2014-04-16 10:17:06.187 | local2.* ~
2014-04-16 10:17:06.188 |
2014-04-16 10:17:06.189 | local3.*;local3.!notice /opt/stack/data/swift/logs/storage2.log
2014-04-16 10:17:06.191 | local3.notice /opt/stack/data/swift/logs/storage2.error
2014-04-16 10:17:06.192 | local3.* ~
2014-04-16 10:17:06.194 |
2014-04-16 10:17:06.195 | local4.*;local4.!notice /opt/stack/data/swift/logs/storage3.log
2014-04-16 10:17:06.197 | local4.notice /opt/stack/data/swift/logs/storage3.error
2014-04-16 10:17:06.198 | local4.* ~
2014-04-16 10:17:06.200 |
2014-04-16 10:17:06.201 | local5.*;local5.!notice /opt/stack/data/swift/logs/storage4.log
2014-04-16 10:17:06.203 | local5.notice /opt/stack/data/swift/logs/storage4.error
2014-04-16 10:17:06.204 | local5.* ~
2014-04-16 10:17:06.206 | + exit_trap
2014-04-16 10:17:06.207 | + local r=1
2014-04-16 10:17:06.209 | ++ jobs -p
2014-04-16 10:17:06.210 | + jobs=
2014-04-16 10:17:06.212 | + [[ -n '' ]]
2014-04-16 10:17:06.213 | + exit 1

[Yves-Gwenael Bourhis (yves-gwenael-bourhis)]

This patch fixes the issue:
https://github.com/bdossantos/devstack/commit/4945953256fc61e985992e829c0f6cf55c97e363

[Yves-Gwenael Bourhis (yves-gwenael-bourhis)]

I'll upload the above patch as a patch-set on gerrit

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/87942

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/87942
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=f894c2ab805f9dfc0dfdd3668ccd3a83ee4eb9f2
Submitter: Jenkins
Branch: master

commit f894c2ab805f9dfc0dfdd3668ccd3a83ee4eb9f2
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Wed Apr 16 13:37:46 2014 +0200

    Do not modify rsyslog files if rsyslog is not used.

    Swift was missing an 'if [[ $SYSLOG != "False" ]]' statement which is used
    by other services, and therefor failed with a 'No such file or directory'
    error when 'SYSLOG=False' was set in localrc.

    Closes-Bug: 1308461

    Change-Id: I8655a955ebb322516d92bee418b93d4cc23bdc5c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/145420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145420
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=afd4ba425d4aa544dd6732955456c3f4ed6190db
Submitter: Jenkins
Branch: stable/icehouse

commit afd4ba425d4aa544dd6732955456c3f4ed6190db
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Wed Apr 16 13:37:46 2014 +0200

    Do not modify rsyslog files if rsyslog is not used.

    Swift was missing an 'if [[ $SYSLOG != "False" ]]' statement which is used
    by other services, and therefor failed with a 'No such file or directory'
    error when 'SYSLOG=False' was set in localrc.

    Closes-Bug: 1308461

    Change-Id: I8655a955ebb322516d92bee418b93d4cc23bdc5c
    (cherry picked from commit f894c2ab805f9dfc0dfdd3668ccd3a83ee4eb9f2)