error with localc.conf with /Q_PLUGIN_CONF_FILE]]

Bug #1294213 reported by Mathieu Rohon
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Ryota Mibu

Bug Description

I use local.conf to populate neutron plugin config file with :

[[post-config|/$Q_PLUGIN_CONF_FILE]]

It give me this error :

touch: cannot touch `/$Q_PLUGIN_CONF_FILE': Permission denied

the workaround is to remove this line :

https://github.com/openstack-dev/devstack/blob/master/lib/config#L85

but it might have side-effects

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/85120

Changed in devstack:
assignee: nobody → Ryota Mibu (r-mibu)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/98951

Changed in devstack:
assignee: Ryota Mibu (r-mibu) → Ian Wienand (iwienand)
Changed in devstack:
assignee: Ian Wienand (iwienand) → Ryota Mibu (r-mibu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on devstack (master)

Change abandoned by Ian Wienand (<email address hidden>) on branch: master
Review: https://review.openstack.org/98951
Reason: https://review.openstack.org/#/c/85120

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/85120
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=410f5c0016a9d3b1fbd42b95ce1402a1c614e3d3
Submitter: Jenkins
Branch: master

commit 410f5c0016a9d3b1fbd42b95ce1402a1c614e3d3
Author: Ryota MIBU <email address hidden>
Date: Fri Apr 4 02:00:31 2014 +0900

    Fix unsubstituted filename creation

    Since merge_config_file() tries to create an unsubstituted config file,
    stack.sh fails due to permission denied in the file creation when you
    use '[[post-config|/$Q_PLUGIN_CONF_FILE]]' and the file does not exist.

    This patch deletes unnecessary 'touch' command, because the file will
    be made by 'iniset' function in the next command line with evaled
    string from 'configfile'.

    This patch also fixes merge_config_group() to use evaled 'configfile'
    when it checks the directory of the config file exists.

    Change-Id: I608847a34143b5c6a1708c180186dd88a32dd44b
    Closes-bug: #1294213

Changed in devstack:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/101559

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (stable/icehouse)

Reviewed: https://review.openstack.org/101559
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=e2738d365ad315f1a9439c618d0db6b854d86cd7
Submitter: Jenkins
Branch: stable/icehouse

commit e2738d365ad315f1a9439c618d0db6b854d86cd7
Author: Ryota MIBU <email address hidden>
Date: Fri Apr 4 02:00:31 2014 +0900

    Fix unsubstituted filename creation

    Since merge_config_file() tries to create an unsubstituted config file,
    stack.sh fails due to permission denied in the file creation when you
    use '[[post-config|/$Q_PLUGIN_CONF_FILE]]' and the file does not exist.

    This patch deletes unnecessary 'touch' command, because the file will
    be made by 'iniset' function in the next command line with evaled
    string from 'configfile'.

    This patch also fixes merge_config_group() to use evaled 'configfile'
    when it checks the directory of the config file exists.

    Change-Id: I608847a34143b5c6a1708c180186dd88a32dd44b
    Closes-bug: #1294213
    (cherry picked from commit 410f5c0016a9d3b1fbd42b95ce1402a1c614e3d3)

tags: added: in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.