cinder_driver_certs.sh always passes driver

Bug #1289129 reported by Ryan McNair
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Ryan McNair

Bug Description

In cinder_driver_certs.sh, the exit code from "./tools/pretty_tox.sh api.volume 2>&1 | tee -a $TEMPFILE", is tested, but this only checks that "tee" ran properly. Even if tests fail, as long as tee exits with status code zero it will say the driver passed.

Example:
FAILED (failures=27, skipped=2)

========================================================
03/06/14/18:51:40:CONGRATULATIONS!!! Device driver PASSED!,
========================================================

Ryan McNair (rdmcnair)
Changed in devstack:
assignee: nobody → Ryan McNair (rdmcnair)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78858

Changed in devstack:
status: New → In Progress
Mike Perez (thingee)
no longer affects: cinder
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/78858
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=0ebf2dfe62b094b1c7e507c75794dbef2bf250cd
Submitter: Jenkins
Branch: master

commit 0ebf2dfe62b094b1c7e507c75794dbef2bf250cd
Author: Ryan McNair <email address hidden>
Date: Fri Mar 7 05:31:56 2014 +0000

    cinder_driver_certs.sh always passes driver

    In cinder_driver_certs.sh, the tests are run and output is
    piped to "tee". Currently, checking the exit code of this
    command only checks that "tee" exited properly. Using the
    pipefail option for this script will ensure the entire
    pipe succeeds before passing a driver.

    Change-Id: I58311aa0e2c779467d39c4477c4ea39d14eda207
    Closes-Bug: #1289129

Changed in devstack:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.