exits if have local changes

[Brant Knudson]

This is with commit 0ed4af02da0bd4a0f757dd8c2156913e6c7a724c

If I've got some local changes, devstack exits now:

...
+ cd /opt/stack/python-keystoneclient
+ git diff --exit-code
+ exit_trap
+ local r=1
+ echo 'exit_trap called, cleaning up child processes'
exit_trap called, cleaning up child processes
++ jobs -p
+ kill
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]

In this case, I had a change in keystoneclient.

Previously, devstack didn't exit when I had local changes... I think it was overwriting/resetting them for a while.

I don't think devstack should exit when there's local changes.

Also, if it's going to exit then it should call kill correctly so that there's no usage.

[Malini Kamalambal (malini-pk)]

I see the same error on Ubuntu 13.10 , with no local changes.

2014-02-28 10:06:58.969 | HEAD is now at 53873a2 Merge "Add py33 trove classifier"
2014-02-28 10:06:58.973 | + git_clone git://git.openstack.org/openstack/oslo.messaging.git /opt/stack/oslo.messaging master
2014-02-28 10:06:58.978 | + GIT_REMOTE=git://git.openstack.org/openstack/oslo.messaging.git
2014-02-28 10:06:58.982 | + GIT_DEST=/opt/stack/oslo.messaging
2014-02-28 10:06:58.986 | + GIT_REF=master
2014-02-28 10:06:58.991 | ++ trueorfalse False False
2014-02-28 10:06:58.994 | + RECLONE=False
2014-02-28 10:06:58.999 | + [[ False = \T\r\u\e ]]
2014-02-28 10:06:59.003 | + echo master
2014-02-28 10:06:59.007 | + egrep -q '^refs'
2014-02-28 10:06:59.011 | + [[ ! -d /opt/stack/oslo.messaging ]]
2014-02-28 10:06:59.015 | + [[ False = \T\r\u\e ]]
2014-02-28 10:06:59.018 | + cd /opt/stack/oslo.messaging
2014-02-28 10:06:59.022 | + git show --oneline
2014-02-28 10:06:59.026 | + head -1
2014-02-28 10:06:59.030 | fb453e4 Convert to oslo.test
2014-02-28 10:06:59.034 | + setup_develop /opt/stack/oslo.messaging
2014-02-28 10:06:59.038 | + local project_dir=/opt/stack/oslo.messaging
2014-02-28 10:06:59.042 | + echo 'cd /opt/stack/requirements; python update.py /opt/stack/oslo.messaging'
2014-02-28 10:06:59.046 | cd /opt/stack/requirements; python update.py /opt/stack/oslo.messaging
2014-02-28 10:06:59.050 | + cd /opt/stack/oslo.messaging
2014-02-28 10:06:59.053 | + git diff --exit-code
2014-02-28 10:06:59.057 | + exit_trap
2014-02-28 10:06:59.061 | + local r=1
2014-02-28 10:06:59.064 | ++ jobs -p
2014-02-28 10:06:59.068 | + jobs=
2014-02-28 10:06:59.072 | + [[ -n '' ]]
2014-02-28 10:06:59.076 | + exit 1

[Dean Troyer (dtroyer)]

Addressed in https://review.openstack.org/#/c/76934/