conditional for creating glance-swift user too strict

[Justin Hopper]

a new user glance-swift was added to the keystone_data.sh. However, it is added only if s-proxy is enabled. Trove declares swift as "swift". the "is_service_enabled" function offered a more flexible way of performing this check. I changed the checks in keystone_data.sh to use this function instead.

[Sushil Kumar (sushil-kumar2)]

badly affected with the change in devstack for uploading the images .....

[Thomas Leaman (thomas-leaman)]

Folks looking to get devstack up and running can replace

`enable_service swift`

with

`enable_service s-proxy
enable_service s-object
enable_service s-container
enable_service s-account`

to work around this problem.

[gordon chung (chungg)]

workaround worked for me.

[Tong Li (litong01)]

Actually this work around does not really work. The problem is that it avoided using swift for glance. So glance won't use swift as
its store, it will use file store. The right fix should be in files/keystone_data.sh to change this line:

    if [[ "$ENABLED_SERVICES" =~ "s-proxy" ]]; then

to this:

    if [[ "$ENABLED_SERVICES" =~ "swift" ]]; then

This will make sure that the user glance-swift will be created, everything will work as it should.

The work around will not have glance using swift, not good.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81105

[gordon chung (chungg)]

this seems to be a dup of bug #1279384. we should probably close one of them.

[Mehdi Abaakouk (sileht)]

I have marked this one as duplicate because the proposed change is obsolete, it rely on the old way to manage keystone data.