Check of $USE_GET_PIP in tools/install_pip.sh is invalid

Bug #1259824 reported by Kiyohiro Adachi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Fix Released
Undecided
Kiyohiro Adachi

Bug Description

Compare the following statement will always be true.

if [[ -n "$USE_GET_PIP" ]]; then
    install_get_pip
else
    install_pip_tarball
fi

So because $USE_GET_PIP is '0' or '1'.

Kiyohiro Adachi (adachi)
Changed in devstack:
assignee: nobody → Kiyohiro Adachi (adachi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to devstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/61328

Changed in devstack:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to devstack (master)

Reviewed: https://review.openstack.org/61328
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=a515a70e2b58912877bdf2952e7812410da647f3
Submitter: Jenkins
Branch: master

commit a515a70e2b58912877bdf2952e7812410da647f3
Author: KIYOHIRO ADACHI <email address hidden>
Date: Wed Dec 11 16:11:28 2013 +0900

    Fixed check method of $USE_GET_PIP

    '[[ -n "$USE_GET_PIP" ]]' always TRUE
    because $USE_GET_PIP is '0' or '1'.

    Change-Id: I73c4c6befe2126882ef21991b2a3fe712b2ac388
    Closes-Bug: #1259824

Changed in devstack:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.