xenapi: devstack should die if unzip not available

[Mate Lakat]

I am using devstack to install OS on an ubuntu + xenserver-core

the unzip utility is not installed, this makes devstack fail in a bad way:

++ wget -nv http://gold.eng.hq.xensource.com/git/internal/builds/nova/archive/refs/citrix-builds/jenkins-os-ctx-test-875.zip -O /tmp/tmp.uzz9KUYGlV --no-check-certificate
2013-10-24 13:33:40 URL:http://gold.eng.hq.xensource.com/gitweb/?p=internal/builds/nova.git;a=snapshot;h=refs/citrix-builds/jenkins-os-ctx-test-875;sf=zip [9186872] -> "/tmp/tmp.uzz9KUYGlV" [1]
++ unzip -q -o /tmp/tmp.uzz9KUYGlV -d /tmp/tmp.Kquw2pOLGV
/tmp/tmp.23EGGNufaH/devstack-refs.citrix-builds.jenkins-os-ctx-test-875-1ef498d/tools/xen/functions: line 45: unzip: command not found

Devstack should die at this point, but it carries on:

+ XAPI_PLUGIN_DIR=/usr/lib/xapi/plugins
++ find_xapi_plugins_dir /tmp/tmp.Kquw2pOLGV
++ find /tmp/tmp.Kquw2pOLGV -path '*/xapi.d/plugins' -type d -print
+ EXTRACTED_PLUGINS_DIR=
+ cp -pr /bin /boot /dev /etc /home /initrd.img /initrd.img.old /lib /lib64 /lost+found /media /mnt /opt /proc /root /run /sbin /selinux /srv /sys /tmp /usr /var /vmlinuz /vmlinuz.old /usr/lib/xapi/plugins

And it's bad.

[Dean Troyer (dtroyer)]

unzip is listed in the regular pre-reqs and there appears to be an unzip() function in tools/xen/mocks. Has this been addressed?

[Mate Lakat (mate-lakat)]

This bit of code is executed before devstack requirements installed - normally, it's running in XenServer's dom0, which has unzip. If we go for xenserver-core, the unzip utility is not installed.

So two problems here:
  if we are using xenserver-core, we should install unzip as part of the script
  the devstack script should terminate, if unzip is unavailable

I'll check if this issue is still valid or not.

Apart from that, we should not rely on github's snapshot feature - for example, the OS repos don't support snapshotting.

The proper fix would be to move the plugin download to domU, and scp the files to dom0 from there.

I filed a bug for the real issue:
https://bugs.launchpad.net/devstack/+bug/1260657

once that's solved, this bug will no longer be valid.