euca exercise can't depend on in-use volume state for volume attachment being complete

[Christopher Yeoh]

the euca.sh tests use euca-describe-volumes to detect when a volume to instance attachment has been completed by looking for the in-use state. This is not correct as the volume could still be in the process of attaching. There is currently a Nova bug https://bugs.launchpad.net/nova/+bug/1074901 (see further issues in comments) where the state of attaching is returned for a volume so the test currently works. But 'attaching' is not a valid ec2 api state and should instead be in-use.

The test instead should look for the attachment state information which accompanies the volume information with euca-describe-volumes. But note that this information will not be displayed until https://review.openstack.org/#/c/27098/ gets through. This fixes the first part of bug 1074901 which removes the extraneous data with the volume state which causes euca-describe-volumes not to display the attachment information for an in-use volume.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/27244

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/27244
Committed: http://github.com/openstack-dev/devstack/commit/c2fc5f890ee5cdc7f4f3957b61d4237bd1abda38
Submitter: Jenkins
Branch: master

commit c2fc5f890ee5cdc7f4f3957b61d4237bd1abda38
Author: Chris Yeoh <email address hidden>
Date: Mon Apr 22 10:33:07 2013 +0930

    Fix attach volume detect in euca test

    Fixes test for detecting when a volume has been successfully
    attached to an instance to not just rely on the state being
    in-use, but also be marked as "attached". The attachment
    state will be displayed when https://review.openstack.org/#/c/27098/
    goes through. The attachment state is not currently displayed
    by euca-describe-volumes because of the extraneous data returned
    by the API as per bug #1074901.

    In the meantime the "attaching" status of the volume itself, rather
    than the attachment state, suffices for the test to work properly, but in the long
    term this will disappear as it is not a valid ec2 API state and
    volumes will move straight to the in-use state.

    Fixes bug #1170548

    Change-Id: Id38f37e1a0efc991f60da35145f809d98b5f41cd