glusterfs_native CI failure: Incorrect configuration of glusterfs volumes to be used as shares.

[Ramana Raja]

The glusterfs_native CI is failing. The manila-share service log reports the following error repeatedly,
ERROR manila.share.drivers.glusterfs_native [req-d5d2a89c-27aa-4177-9218-d94b729723fe ] Option auth.ssl-allow is not defined on gluster volume. Volume: manila-glusterfs-native-vol-20G-11
ERROR manila.share.manager [req-d5d2a89c-27aa-4177-9218-d94b729723fe ] Share instance 37c1e2b9-34f5-4702-9dc9-5ca55b97174d failed on creation.

The auth.ssl-allow option needs to be set for a GlusterFS volume to be used as a share. Looking at the devstacklog (setup log), figured that this configuration step does not happen for every volume that is created and is to
be used as a share.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/254035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254035
Committed: https://git.openstack.org/cgit/openstack/devstack-plugin-glusterfs/commit/?id=28fc5d375fbf13ac6d102acc71de2eb3eeb29d1c
Submitter: Jenkins
Branch: master

commit 28fc5d375fbf13ac6d102acc71de2eb3eeb29d1c
Author: Ramana Raja <email address hidden>
Date: Mon Dec 7 12:15:09 2015 +0530

    Restrict scope of loop control variables to local

    Some of the loop control variables are global. This as expected has
    lead to corruption of their values, and produced undesired results.
    Fix this issue by setting the scope of these variables to local.

    Closes Bug: #1523348

    Change-Id: I0f5676c5a0b97d3e027a1e7677b4b5a21470913b