[md-importer] Figure out how to display images
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Ubuntu Developer Portal |
Medium
|
Daniel Holbach | ||
Bug Description
Figure out how to display images in imported markdown docs. /snappy/build-apps should have one.
Related branches
- Ubuntu App Developer site developers: Pending requested 2015-12-22
-
Diff: 1625 lines (+953/-399)28 files modifiedTODO (+13/-0)
developer_portal/admin.py (+1/-18)
developer_portal/migrations/0001_initial.py (+0/-9)
developer_portal/models.py (+0/-21)
developer_portal/settings.py (+2/-0)
locale/de.po (+2/-2)
locale/en_GB.po (+2/-2)
locale/es.po (+2/-2)
locale/ug.po (+2/-2)
locale/zh_CN.po (+2/-2)
md_importer/admin.py (+36/-0)
md_importer/management/commands/import-external-docs-branches.py (+35/-335)
md_importer/management/importer/article.py (+118/-0)
md_importer/management/importer/publish.py (+64/-0)
md_importer/management/importer/repo.py (+168/-0)
md_importer/management/importer/source.py (+60/-0)
md_importer/migrations/0001_initial.py (+46/-0)
md_importer/models.py (+54/-0)
md_importer/tests/__init__.py (+8/-0)
md_importer/tests/data/link-test/file1.md (+5/-0)
md_importer/tests/data/link-test/file2.md (+3/-0)
md_importer/tests/test_branch_fetch.py (+42/-0)
md_importer/tests/test_branch_import.py (+67/-0)
md_importer/tests/test_link_rewrite.py (+44/-0)
md_importer/tests/test_snappy_import.py (+70/-0)
md_importer/tests/test_utils.py (+33/-0)
md_importer/tests/utils.py (+67/-0)
requirements.txt (+7/-6)
- Ubuntu App Developer site developers: Pending requested 2015-11-17
-
Diff: 886 lines (+636/-75) (has conflicts)12 files modifiedTODO (+7/-0)
developer_portal/admin.py (+22/-4)
developer_portal/management/commands/import-external-docs-branches.py (+42/-56)
developer_portal/management/importer/article.py (+126/-0)
developer_portal/management/importer/local_branch.py (+132/-0)
developer_portal/management/importer/publish.py (+60/-0)
developer_portal/management/importer/source.py (+51/-0)
developer_portal/migrations/0002_rework_importer.py (+59/-0)
developer_portal/migrations/0003_track_imported_articles.py (+24/-0)
developer_portal/models.py (+46/-15)
developer_portal/settings.py (+20/-0)
requirements.txt (+47/-0)
| summary: |
- Figure out how to display images in imported markdown docs + [md-importer] Figure out how to display images |
| Changed in developer-ubuntu-com: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: site-dev |
| Daniel Holbach (dholbach) wrote : | #1 |
| Daniel Holbach (dholbach) wrote : | #2 |
I can see two options:
1) ship the image in trunk, make it show up in markdown too
+ produced markdown docs look the same as ours
+ less monkeying around with the produced HMTL
- needs upload of images to swift
- needs us to figure out how make it look well with markdown
2) have a custom solution, like setting a "hero picture" for a given article
+ no monkeying around with markdown
- needs picture upload capability
- needs new table for ImportedMarkdow
Anything I've missed or forgotten?
| Daniel Holbach (dholbach) wrote : | #3 |
| Daniel Holbach (dholbach) wrote : | #4 |
Both would require us to keep track of the image, so remove it if it gets dropped from the article or the article gets deleted.
| Daniel Holbach (dholbach) wrote : | #5 |
Option 3:
<davidcalle> dholbach, I would say: hosting images in the docs dir in snapcraft, and using the proper markdown extension (there is one for images). To have something that would work both and github and d.u.c, with images hosted on github
<dholbach> so we'd hotlink to the image on github? or did I misunderstand
<davidcalle> dholbach, yes we would
| Changed in developer-ubuntu-com: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Daniel Holbach (dholbach) |
| Changed in developer-ubuntu-com: | |
| status: | In Progress → Fix Committed |
| Changed in developer-ubuntu-com: | |
| status: | Fix Committed → Fix Released |
David: do you have an idea how we could do this?