Cannot approve or reject application in the Needs Information state

[Andrew Mitchell]

The ARB needs to be able to reject applications that have been in the Needs Information state for some time, where the application submitter has not replied. There currently doesn't look to be any way to change the state from Needs Information for ARB reviewers, e.g. on https://myapps.developer.ubuntu.com/dev/apps/398/feedback/

[Anthony Lenton (elachuni)]

Discussed with ajmitch.

Allowing reviewers to force NeedsInformation -> PendingReview sounds reasonable, as this is most often due to the developer intending to put the app back into the review queue, but failing to notice the subtly different side-effects of the "Resubmit for review" and "Send comment" buttons.

Another requested transition is NeedsInformation -> Rejected and NeedsInformation -> QAPending. These are trickier because they would usually require you to provide extra information (a reason for rejection, or a package name + supported distro arch series for approval). We could allow the former by just filling in a blank reason for the rejection, but I'd be more inclined to only allow NeedsInformation->PendingReview, and the reviewer can then take it from there, moving it forwards to Rejected or QAPending through the usual review process.

[Danny Tamez (zematynnad)]

From mumble conversation with achuni:

Two scenarios : 1) a developer provides feedback and we can't change the state since it's in needs info (we should instead change the state to review pending when the dev leaves feedback) - this will become a separate bug and branch.
                               2) app sits in needs info for too long and the dev doesn't respond. - we will provide a button that is accessible to any reviewer. The button will move the application back into review pending
This will be more general and more flexible than just rejecting the app because they took too long but it will hit the developer with more email. As part of this branch we should look at removing the email that is sent when the transition is made from needs info to review pending. The transition log however should still be kept so that the action still shows up in the app history notes.

[Danny Tamez (zematynnad)]

The bug for scenario 1 above is at http://pad.lv/987996