Adding Gnome-Shell support

[Eric Gach]

I've created a patch that adds a module for gnome-shell to change the background. This patch uses the dconf library to change the wallpaper. Not sure how perfect it is, but its a start.

[Richard Gobeille (rich-envision7)]

There's a typo in your CMakeLists.txt alterations that prevent your module from loading due to libdconf not being linked in. You've got IF(ENABLED_MODULE_GNOME_SHELL) instead of IF(ENABLE_MODULE_GNOME_SHELL), so the condition is never triggered and the DCONF_LIBRARIES macro is never generated.

Otherwise, nice work; this was one of the must have things that put me off of moving to GNOME 3.

[Stefan Haller (haliner)]

Thank you for improving DesktopNova, good job.

You did not state how your code is licensed. May I use your code in the terms of the GPLv3? I just want to be sure, before I start integrating it.

[Eric Gach (egach)]

Yes GPLv3 is fine with me. Sorry about that.

[onttwowheels (wick-carl-s)]

How is this patch applied? I would like to get DN working with Gnome 3. Thanks for any input.

[Stefan Haller (haliner)]

You need to get the latest source of DesktopNova from the download page. Applying the patch most likely should work:

  cd /patch/to/source
  patch <gnome-shell.patch

After this you need to compile and install DesktopNova. (You could also modify the Debian source package, so that it applies the patch before compilation.)

After finishing my exams tomorrow, I will backport the Gnome Shell patch back to the latest stable release. This will happen in the next week (when I have the time).

Until now I didn't give Gnome Shell or Unity a try, but supporting them seems important to me — the next release definitely should have included the necessary things.

[onttwowheels (wick-carl-s)]

I was afraid it was going to require a compile :-) Thanks, if I get some time I'll give it a try.

[onttwowheels (wick-carl-s)]

Has Gnome Shell support been added yet?

[ontwowheels (wick-carl)]

yes, no, maybe?

[onttwowheels (wick-carl-s)]

Never in a million years don't even think about it????

[Stefan Haller (haliner)]

Before I integrate this patch, I want to clean up the code completely. I wrote the first version of the program a long time ago and I hadn’t all the things in mind which are necessary today. I’m searching for the things I made “wrong” in the early development of the project and I want to fix them up.

Please don’t be impatient. This is my free time and unfortunately I can’t spend much time currently.

[onttwowheels (wick-carl-s)]

OK, THANKS for the update. Since switching to Gnome3 and Gnome shell I have missed this program.

[Stefan Haller (haliner)]

Scheduled for the next release. DesktopNova 0.9 will be almost completely rewritten, so I have a lot to do. Do not expect a fast fix or release.

[Baptiste Wicht (baptistewicht)]

Is you patch likely to work on Linux mint with MGSE ?

[Ron Murray (rjmx)]

Eric, there appears to be another error in your patch. Line 69:

> + TARGET_LINK_LIBRARIES(desktopnova-module-gnome ${DCONF_LIBRARIES})

should be

> + TARGET_LINK_LIBRARIES(desktopnova-module-gnome-shell ${DCONF_LIBRARIES})

   Without this change, the module won't load (and won't appear in the GUI under "Modules" due to an unsatisfied entry point.

   I've produced some Debian packages (based on version 0.8.1, of course) and have it installed. It seems to work ok, except for:

- Double-clicking on the tray icon doesn't bring up the GUI. You can bring it up by right-clicking on the icon and selecting "Preferences", though.

- Mouse wheel doesn't change to previous/next image. Don't know why.

- GUI crashes after saving settings, probably due to Ubuntu bug #987906.