the fieldmapping transformer methods should return transformed data, rather than manipulating their arguments
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
desktopcouch |
Fix Released
|
Medium
|
Eric Casteleijn | ||
desktopcouch (Ubuntu) |
Fix Released
|
Medium
|
Eric Casteleijn |
Bug Description
These two methods in field_registry.py should return results, rather than modify their second argument.
def from_app(self, data, record):
for key, val in data.items():
if key in self.field_
else:
def to_app(self, record, data):
annotations = record.
for key, value in annotations.
for key in self.field_
Related branches
- Chad Miller (community): Approve
- Vincenzo Di Somma (community): Approve
- dobey (community): Approve
-
Diff: 1532 lines (+273/-188)13 files modified.bzrignore (+2/-0)
bin/desktopcouch-pair (+41/-41)
data/source_desktopcouch.py (+1/-1)
desktopcouch/pair/couchdb_pairing/couchdb_io.py (+5/-5)
desktopcouch/pair/tests/test_couchdb_io.py (+3/-3)
desktopcouch/records/doc/field_registry.txt (+21/-16)
desktopcouch/records/field_registry.py (+16/-9)
desktopcouch/records/server.py (+16/-14)
desktopcouch/records/server_base.py (+53/-32)
desktopcouch/records/tests/test_field_registry.py (+50/-15)
desktopcouch/records/tests/test_record.py (+20/-20)
desktopcouch/records/tests/test_server.py (+44/-31)
utilities/lint.sh (+1/-1)
Changed in desktopcouch: | |
milestone: | none → 0.6 |
Changed in desktopcouch: | |
milestone: | 0.6 → 1.0 |
Changed in desktopcouch: | |
status: | Triaged → In Progress |
Changed in desktopcouch: | |
status: | In Progress → Fix Committed |
Changed in desktopcouch (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Eric Casteleijn (thisfred) |
milestone: | none → natty-alpha-1 |
Changed in desktopcouch (Ubuntu): | |
milestone: | natty-alpha-1 → natty-alpha-2 |
Changed in desktopcouch: | |
status: | Fix Committed → Fix Released |
Changed in desktopcouch (Ubuntu): | |
status: | In Progress → Fix Released |