Zone Manager exists event emits Designate obj representiations

Bug #1545658 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Kiall Mac Innes
Liberty
Fix Committed
High
Kiall Mac Innes

Bug Description

Emitted data looks like the following:

    {'shard': 1422, 'minimum': 3600, 'parent_domain_id': None, 'ttl': 3600, 'serial': 1455530319, 'deleted_at': None, 'id': u'58ebb5eb-595c-468d-a90a-0ee468cd0352', 'retry': 600, 'deleted': u'0', 'version': 4, 'type': u'PRIMARY', 'email': <email address hidden>', 'status': u'ACTIVE', 'description': None, 'transferred_at': None, 'updated_at': u'2016-02-15T09:59:32.000000', 'audit_period_ending': '2016-02-15 10:12:02.326931', 'expire': 86400, 'audit_period_beginning': '2016-02-15 09:12:02.326931', 'masters': <designate.objects.domain_master.DomainMasterList object at 0x7fdc96264550>, 'name': u'example.net.', 'tenant_id': u'a178fffba40140e08525570478ce30cf', 'created_at': u'2016-02-15T09:58:40.000000', 'pool_id': u'794ccc2c-d751-44fe-b57f-8894c9f5c842', 'refresh': 3600, 'action': u'NONE', 'attributes': <designate.objects.domain_attribute.DomainAttributeList object at 0x7fdc96264f90>}

It should not have any designate.objects references.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280161

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/280163

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/280161
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=0022fd85b6cc91425eb0d87f066c162c0074ca0d
Submitter: Jenkins
Branch: master

commit 0022fd85b6cc91425eb0d87f066c162c0074ca0d
Author: Kiall Mac Innes <email address hidden>
Date: Mon Feb 15 11:13:40 2016 +0000

    Ensure ZoneManager emits valid objects

    Zone Manager exists events have been sending Designate obj
    representiations rather than plain dicts. Additionally,
    the audit period values were not in the correct format
    due to an explicit datetime -> str cast vs allowing the
    serializer to handle the conversion.

    Additionally, remove duplicated RoObject class and implement
    the to_dict() method.

    Change-Id: I6892433b5c112563901dbac2b477bf3d9e56217b
    Closes-Bug: 1545658

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/280163
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=4047dc24cae838525b78245f3d2ee84455b49d9e
Submitter: Jenkins
Branch: stable/liberty

commit 4047dc24cae838525b78245f3d2ee84455b49d9e
Author: Kiall Mac Innes <email address hidden>
Date: Mon Feb 15 11:13:40 2016 +0000

    Ensure ZoneManager emits valid objects

    Zone Manager exists events have been sending Designate obj
    representiations rather than plain dicts. Additionally,
    the audit period values were not in the correct format
    due to an explicit datetime -> str cast vs allowing the
    serializer to handle the conversion.

    Additionally, remove duplicated RoObject class and implement
    the to_dict() method.

    Change-Id: I6892433b5c112563901dbac2b477bf3d9e56217b
    Closes-Bug: 1545658

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b3

This issue was fixed in the openstack/designate 2.0.0.0b3 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/designate 1.0.2

This issue was fixed in the openstack/designate 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/designate 1.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.