Designate

max_request_body_size setting does not work

Bug #2036642 reported by Michael Johnson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Erik Olof Gunnar Andersson

Bug Description

The [oslo_middleware] max_request_body_size setting in designate.conf does not work by default.

Setting it to 1 still allows the API to accept zone create calls.

OpenStack Infra (hudson-openstack)
Changed in designate:
status: New → In Progress
Erik Olof Gunnar Andersson (eandersson)
Changed in designate:
assignee: theongrey (eanderson) → Erik Olof Gunnar Andersson (eandersson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/894895
Committed: https://opendev.org/openstack/designate/commit/c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68
Submitter: "Zuul (22348)"
Branch: master

commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/designate/+/896702

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/designate/+/896703

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/designate/+/896704

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/designate/+/896705

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/designate/+/896727

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/designate/+/896706

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/designate/+/896707

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/designate/+/896708

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896708
Committed: https://opendev.org/openstack/designate/commit/08ceeb0664a95a60d737791314dd48544e6b5e94
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 08ceeb0664a95a60d737791314dd48544e6b5e94
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

tags: added: in-stable-ussuri
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896727
Committed: https://opendev.org/openstack/designate/commit/248cf3076c69f754802eae507a75926a08827f2a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 248cf3076c69f754802eae507a75926a08827f2a
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896702
Committed: https://opendev.org/openstack/designate/commit/c918e5cea2a11b16e6e9a22e3a6a4e9901856199
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit c918e5cea2a11b16e6e9a22e3a6a4e9901856199
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896705
Committed: https://opendev.org/openstack/designate/commit/2dda2843c10960e98eed86510cf66a34f293e804
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 2dda2843c10960e98eed86510cf66a34f293e804
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896704
Committed: https://opendev.org/openstack/designate/commit/71743f9f992f2c9a9a8a5c1a14d9d38162314391
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 71743f9f992f2c9a9a8a5c1a14d9d38162314391
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896707
Committed: https://opendev.org/openstack/designate/commit/bfa7e03dd374bf69dcbc6a542695dcc5d24bd0d9
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit bfa7e03dd374bf69dcbc6a542695dcc5d24bd0d9
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896706
Committed: https://opendev.org/openstack/designate/commit/c9945e11e75b1382a202d3ed0c967eb802857c8d
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c9945e11e75b1382a202d3ed0c967eb802857c8d
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896703
Committed: https://opendev.org/openstack/designate/commit/07611d51655a16eefaae19ad345d89f93e46ff01
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 07611d51655a16eefaae19ad345d89f93e46ff01
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Tue Sep 19 13:23:12 2023 -0700

    Add middleware to limit request body size to api-paste

    Closes-Bug: #2036642
    Change-Id: Ia4d50ff0b39e3a7ed31829fbabeae4fd24cf49c9
    (cherry picked from commit c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to designate-tempest-plugin (master)

Reviewed: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/896888
Committed: https://opendev.org/openstack/designate-tempest-plugin/commit/770507655a3d4dfb8cb3da2c63affda71032b4f3
Submitter: "Zuul (22348)"
Branch: master

commit 770507655a3d4dfb8cb3da2c63affda71032b4f3
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Oct 5 03:54:59 2023 -0700

    Use reasonable sizes for negative tests

    These tests had numbers large enough to trigger the middleware
    to limit the request body.

    Related-Bug: #2036642
    Change-Id: Ie0c07199b0f0257452aa0e0fb5a4bfe546c7de29

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 15.0.2

This issue was fixed in the openstack/designate 15.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 16.0.2

This issue was fixed in the openstack/designate 16.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 14.0.4

This issue was fixed in the openstack/designate 14.0.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 17.0.1

This issue was fixed in the openstack/designate 17.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate ussuri-eol

This issue was fixed in the openstack/designate ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate victoria-eom

This issue was fixed in the openstack/designate victoria-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate wallaby-eom

This issue was fixed in the openstack/designate wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate xena-eom

This issue was fixed in the openstack/designate xena-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 18.0.0.0rc1

This issue was fixed in the openstack/designate 18.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.