designate-manage pool update may fail with MissingProjectID

Bug #1986733 reported by Michael Johnson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Michael Johnson

Bug Description

The "designate-manage pool update" may fail when attempting to add a new pool with the following error:
ERROR designate designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/853370

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/853370
Committed: https://opendev.org/openstack/designate/commit/a03c4657c2bf957fef035807ef7df732f7a1c994
Submitter: "Zuul (22348)"
Branch: master

commit a03c4657c2bf957fef035807ef7df732f7a1c994
Author: Michael Johnson <email address hidden>
Date: Tue Aug 16 22:17:39 2022 +0000

    Fix designate-manage pool update MissingProjectID

    This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

    designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

    There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

    This patch removes that check, but retains the RBAC check for and "admin" token.

    Closes-Bug: #1986733
    Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/designate/+/853638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/designate/+/853639

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/designate/+/853640

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/designate/+/853638
Committed: https://opendev.org/openstack/designate/commit/9d96cc843aa54582db52b394ad8223a1939ac05e
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 9d96cc843aa54582db52b394ad8223a1939ac05e
Author: Michael Johnson <email address hidden>
Date: Tue Aug 16 22:17:39 2022 +0000

    Fix designate-manage pool update MissingProjectID

    This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

    designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

    There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

    This patch removes that check, but retains the RBAC check for and "admin" token.

    Closes-Bug: #1986733
    Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f
    (cherry picked from commit a03c4657c2bf957fef035807ef7df732f7a1c994)

tags: added: in-stable-yoga
tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/designate/+/853639
Committed: https://opendev.org/openstack/designate/commit/f674574fe7b9fe170af1ec0e170ed01bb0e19b79
Submitter: "Zuul (22348)"
Branch: stable/xena

commit f674574fe7b9fe170af1ec0e170ed01bb0e19b79
Author: Michael Johnson <email address hidden>
Date: Tue Aug 16 22:17:39 2022 +0000

    Fix designate-manage pool update MissingProjectID

    This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

    designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

    There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

    This patch removes that check, but retains the RBAC check for and "admin" token.

    Closes-Bug: #1986733
    Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f
    (cherry picked from commit a03c4657c2bf957fef035807ef7df732f7a1c994)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/designate/+/853640
Committed: https://opendev.org/openstack/designate/commit/bf634b829b370e9e66dbecd436b3d6592886c576
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit bf634b829b370e9e66dbecd436b3d6592886c576
Author: Michael Johnson <email address hidden>
Date: Tue Aug 16 22:17:39 2022 +0000

    Fix designate-manage pool update MissingProjectID

    This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

    designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

    There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

    This patch removes that check, but retains the RBAC check for and "admin" token.

    Closes-Bug: #1986733
    Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f
    (cherry picked from commit a03c4657c2bf957fef035807ef7df732f7a1c994)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 15.0.0.0rc1

This issue was fixed in the openstack/designate 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 13.0.2

This issue was fixed in the openstack/designate 13.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 14.0.2

This issue was fixed in the openstack/designate 14.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate wallaby-eom

This issue was fixed in the openstack/designate wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.