CAA records don't allow email subadresses in mail URL

Bug #1958533 reported by Christian Rohmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Unassigned

Bug Description

Currently a CAA record does not allow for email subadresses (+ notation after local part) to be used:

1) While this works fine:

$ openstack recordset set myzone myrecord.myzone. --record '0 issue letsencrypt.org' --record '0 iodef mailto:<email address hidden>'

2) This does not:

$ openstack recordset set myzone myrecord.myzone. --record '0 issue letsencrypt.org' --record '0 iodef mailto:<email address hidden>'

'0 iodef mailto:<email address hidden>' is not a 'CAA' Record

It's simply due to the regex checking for a valid mail url not including this: https://opendev.org/openstack/designate/src/commit/bff3d5f6e31fe595a77143ec4ac779c187bf72a8/designate/objects/fields.py#L103

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/825512

Changed in designate:
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/825512
Committed: https://opendev.org/openstack/designate/commit/1cef20edbc462fab75a919fc0de796c2d6edb30b
Submitter: "Zuul (22348)"
Branch: master

commit 1cef20edbc462fab75a919fc0de796c2d6edb30b
Author: Christian Rohmann <email address hidden>
Date: Thu Jan 20 15:20:35 2022 +0100

    Allow email subadresses to be used within mail url of CAA records

    This patch allows for +subaddress to be used for the local part of mail urls
    used for CAA records. While there are more characters allowed in email
    addresses, using subadresses for incoming email to role accounts is quite
    common.

    Closes-Bug: 1958533
    Change-Id: Id265fa1dfa5c0703d8e95b5de1334d4ca716fbc0

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 14.0.0.0rc1

This issue was fixed in the openstack/designate 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/designate/+/844373

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/designate/+/844374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/designate/+/844374
Committed: https://opendev.org/openstack/designate/commit/53cf9b96f58decad03c3e4dedbb33d7b5777a6b0
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 53cf9b96f58decad03c3e4dedbb33d7b5777a6b0
Author: Christian Rohmann <email address hidden>
Date: Thu Jan 20 15:20:35 2022 +0100

    Allow email subadresses to be used within mail url of CAA records

    This patch allows for +subaddress to be used for the local part of mail urls
    used for CAA records. While there are more characters allowed in email
    addresses, using subadresses for incoming email to role accounts is quite
    common.

    Closes-Bug: 1958533
    Change-Id: Id265fa1dfa5c0703d8e95b5de1334d4ca716fbc0
    (cherry picked from commit 1cef20edbc462fab75a919fc0de796c2d6edb30b)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/designate/+/844373
Committed: https://opendev.org/openstack/designate/commit/0b818283fd5a676fda6c42a0a1d37723fb170e34
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0b818283fd5a676fda6c42a0a1d37723fb170e34
Author: Christian Rohmann <email address hidden>
Date: Thu Jan 20 15:20:35 2022 +0100

    Allow email subadresses to be used within mail url of CAA records

    This patch allows for +subaddress to be used for the local part of mail urls
    used for CAA records. While there are more characters allowed in email
    addresses, using subadresses for incoming email to role accounts is quite
    common.

    Closes-Bug: 1958533
    Change-Id: Id265fa1dfa5c0703d8e95b5de1334d4ca716fbc0
    (cherry picked from commit 1cef20edbc462fab75a919fc0de796c2d6edb30b)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 13.0.1

This issue was fixed in the openstack/designate 13.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 12.1.0

This issue was fixed in the openstack/designate 12.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.