Invalid MX record during recordset create/update cause ZONE to enter in Error state

[kiran pawar]

In Designate it is not possible to create an MX (Mail) record without a . (dot) at the end of fqdn. Which is the way it should be per RFC.
However, Designate allows users to update the MX record and omit/remove the . (dot) at the end of fqdn.

Case 1)
openstack recordset create --record "20 xxxx.test.com" --type MX zone_id mail2.test.com.

Case 2)
openstack recordset create --record "20 xxxx.test.com." --type MX zone_id mail2.test.com.
openstack recordset set --record "20 xxxx.test.com" --type MX zone_id recordset_id

In either of case 1 or 2, causes the zone to be stuck in PENDING and go to ERROR at some point, because the backend server (Bind) cannot fetch the zone from Designate-mdns.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/790000

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/designate/+/790000
Committed: https://opendev.org/openstack/designate/commit/536315e38ccc06193d9f8b83770aab8f671f6fa8
Submitter: "Zuul (22348)"
Branch: master

commit 536315e38ccc06193d9f8b83770aab8f671f6fa8
Author: kpdev <email address hidden>
Date: Thu May 6 06:56:11 2021 +0200

    Validate MX records during recordset create or update

    If invalid MX record is provided during recordset create command or
    valid record is updated to invalid record using recordset set command,
    causes recordset creation/updation failure. This leads to zone enter
    in ERROR state and all further recordset creation calls fail. Validate
    the records within recordset during create or update call.

    Closes-Bug: #1927304
    Change-Id: I0ace4d6c4ad6a6ee236e3af23805b01345d60a42

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 15.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/designate/+/877164

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/designate/+/877164
Committed: https://opendev.org/openstack/designate/commit/86a8cc5f525f6e2ab5e287c027b3bd18b9fbfbd3
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 86a8cc5f525f6e2ab5e287c027b3bd18b9fbfbd3
Author: kpdev <email address hidden>
Date: Thu May 6 06:56:11 2021 +0200

    Validate MX records during recordset create or update

    If invalid MX record is provided during recordset create command or
    valid record is updated to invalid record using recordset set command,
    causes recordset creation/updation failure. This leads to zone enter
    in ERROR state and all further recordset creation calls fail. Validate
    the records within recordset during create or update call.

    Closes-Bug: #1927304
    Change-Id: I0ace4d6c4ad6a6ee236e3af23805b01345d60a42

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 14.0.2 release.