designate-sink stuck shutting down when no handler is configured

Bug #1877201 reported by Erik Olof Gunnar Andersson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Erik Olof Gunnar Andersson

Bug Description

If no notification handler is configured the designate-sink can get stuck shutting down. This can cause CI failures.
> Possible hang: stop is waiting for start to complete

Changed in designate:
assignee: nobody → Erik Olof Gunnar Andersson (eandersson)
status: New → In Progress
Changed in designate:
assignee: Erik Olof Gunnar Andersson (eandersson) → Dr. Jens Harbott (j-harbott)
Changed in designate:
importance: Undecided → Critical
assignee: Dr. Jens Harbott (j-harbott) → Erik Olof Gunnar Andersson (eandersson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/ussuri)

Reviewed: https://review.opendev.org/725977
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=0d52d83697bfd786481be630726530cc27e1b830
Submitter: Zuul
Branch: stable/ussuri

commit 0d52d83697bfd786481be630726530cc27e1b830
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Wed May 6 10:54:11 2020 -0700

    Fix designate-sink shutdown issue

    If no notification handler is configured the
    designate-sink may not shutdown properly.
    This is because the listener was created but never
    started. This caused oslo.messaging to hang on
    waiting for a successful start before stopping.

    Closes-Bug: #1877201
    Change-Id: Ie51f7c3d64cbb48ae359256b6fa5a0196fb3f248
    (cherry picked from commit 40cbc9bd43d3b43d6cdc4daeb5a089df96603ed7)

tags: added: in-stable-ussuri
Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/725948
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=3c4d9f67119e11d66924bd6941f7b33de72875bf
Submitter: Zuul
Branch: master

commit 3c4d9f67119e11d66924bd6941f7b33de72875bf
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Wed May 6 10:54:11 2020 -0700

    Fix designate-sink shutdown issue

    If no notification handler is configured the
    designate-sink may not shutdown properly.
    This is because the listener was created but never
    started. This caused oslo.messaging to hang on
    waiting for a successful start before stopping.

    Depends-On: https://review.opendev.org/725977
    Closes-Bug: #1877201
    Change-Id: Ie51f7c3d64cbb48ae359256b6fa5a0196fb3f248

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.