after create secondary zone, the zone will loop xfr

Bug #1856442 reported by ZhouHeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Mitya Eremeev

Bug Description

when create a secondary zone.the zone will perform zone xfr from master.
Normally, only one xfr should be performed. but not is loop xfr.

ZhouHeng (zhouhenglc)
Changed in designate:
assignee: nobody → ZhouHeng (zhouhenglc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/699106

Changed in designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by "Erik Olof Gunnar Andersson <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/designate/+/699106

Mitya Eremeev (mitos)
Changed in designate:
assignee: ZhouHeng (zhouhenglc) → Mitya Eremeev (mitos)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/864131

Revision history for this message
Mitya Eremeev (mitos) wrote :

1. create secondary zone

Expected behavior:
during creation only one AXFR transfer happens

Actual behavior:
during creation AXFR transfer loops indefinitely. Zone status moves in Pending and Active all the time.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/864131
Committed: https://opendev.org/openstack/designate/commit/964562cc65ccf5619fe53c7b60898edec3b0605b
Submitter: "Zuul (22348)"
Branch: master

commit 964562cc65ccf5619fe53c7b60898edec3b0605b
Author: Mitya_Eremeev <email address hidden>
Date: Wed Nov 9 20:09:12 2022 +0300

    Secondary zone loops AXFR transfer during zone creation

    When we create a secondary zone, AXFR transfer loops indefinitely.
    Normally, only one xfr should be performed.
    Due to AXFR loop the zone changes status from active to pending all the time.

    Co-Authored-By: ZhouHeng <email address hidden>
    Closes-Bug: 1856442
    Change-Id: I0e0d138049e6d4c31dea3cc6768cc15e59a5942c

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 17.0.0.0rc1

This issue was fixed in the openstack/designate 17.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/896062

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896062
Committed: https://opendev.org/openstack/designate/commit/ecaff9e6d348ce3b47a4b4fb71896951274191cb
Submitter: "Zuul (22348)"
Branch: master

commit ecaff9e6d348ce3b47a4b4fb71896951274191cb
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Sep 21 05:28:45 2023 -0700

    Fix AXFR loop when updating secondary zone

    When a secondary zone is created or updated we trigger an AXFR,
    this AXFR then goes ahead and updates the zone. This then causes
    the AXFR code to get triggered again as it thinks the masters
    has changed.

    We fix this by ensuring that when we update the zone from the AXFR
    code that we always reset the masters field.

    Partial-Bug: #1856442
    Change-Id: Ifc2efb5a6d1091ff16373f3cbe3846f5e4371272

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/designate/+/896648

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/designate/+/896648
Committed: https://opendev.org/openstack/designate/commit/b1ecf814a8ef4626dcf6a435e84a18152636ef1d
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit b1ecf814a8ef4626dcf6a435e84a18152636ef1d
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Sep 21 05:28:45 2023 -0700

    Fix AXFR loop when updating secondary zone

    When a secondary zone is created or updated we trigger an AXFR,
    this AXFR then goes ahead and updates the zone. This then causes
    the AXFR code to get triggered again as it thinks the masters
    has changed.

    We fix this by ensuring that when we update the zone from the AXFR
    code that we always reset the masters field.

    Partial-Bug: #1856442
    Change-Id: Ifc2efb5a6d1091ff16373f3cbe3846f5e4371272
    (cherry picked from commit ecaff9e6d348ce3b47a4b4fb71896951274191cb)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.