Overriding a topic causes designate to fail to start

Bug #1832799 reported by Erik Olof Gunnar Andersson on 2019-06-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Undecided
Erik Olof Gunnar Andersson

Bug Description

If any of the topics are overridden in the configuration it causes the application to crash at startup, e.g.

[service:central]
central_topic=fun_central

[service:mdns]
mdns_topic=fun_mdns

[service:worker]
worker_topic=fun_worker

CRITICAL designate [-] Unhandled error: NoSuchOptError: no such option service:fun_central in group [DEFAULT]
ERROR designate Traceback (most recent call last):
ERROR designate File "/usr/local/bin/designate-central", line 10, in <module>
ERROR designate sys.exit(main())
ERROR designate File "/opt/stack/designate/designate/cmd/central.py", line 41, in main
ERROR designate server = central.Service(threads=CONF['service:central'].threads)
ERROR designate File "/opt/stack/designate/designate/central/service.py", line 193, in __init__
ERROR designate super(Service, self).__init__(threads=threads)
ERROR designate File "/opt/stack/designate/designate/service.py", line 131, in __init__
ERROR designate super(RPCService, self).__init__(*args, **kwargs)
ERROR designate File "/opt/stack/designate/designate/service.py", line 64, in __init__
ERROR designate self._service_config = CONF['service:%s' % self.service_name]
ERROR designate File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2201, in __getitem__
ERROR designate return self.__getattr__(key)
ERROR designate File "/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py", line 2197, in __getattr__
ERROR designate raise NoSuchOptError(name)
ERROR designate NoSuchOptError: no such option service:fun_central in group [DEFAULT]
ERROR designate

Changed in designate:
assignee: nobody → Erik Olof Gunnar Andersson (eandersson)
status: New → In Progress

Reviewed: https://review.opendev.org/665268
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=fcb3290be7caf04b6b065f8a25bc4b8a3fd9113a
Submitter: Zuul
Branch: master

commit fcb3290be7caf04b6b065f8a25bc4b8a3fd9113a
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Jun 13 17:24:50 2019 -0700

    Fixed renaming topic breaking service

    Changing the topic currently changes the service_name. This
    breaks the service, as the service_name is also used to
    load the appropriate configuration seection for the service.

    > self._service_config = CONF['service:%s' % self.service_name]

    * Renames cfg option [service:<name>].<name>_topic to [service:<name>].topic
    * Removed previously unused configs related to topics.
    * Added topic override for producer.
    * Added test coverage.

    Closes-Bug: #1832799
    Change-Id: I16385361ec25025aa533df80793dfc4d22151cbb

Changed in designate:
status: In Progress → Fix Released

This issue was fixed in the openstack/designate 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers