Designate Worker does not send 'also_notifies'

[Dmitry Galkin]

Hello,

Pool manager previously had a possibility to send NOTIFY messages to a list of DNS servers specified in the pools.yaml under 'also_notifies' list: https://docs.openstack.org/designate/pike/admin/pools.html

According to docs, that is still possible, but when using designate-worker this does not work.

Expected:
Worker sends NOTIFY message also to all hosts as specified in pools.yaml for respective pool.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/589409

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/589409
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=6e79c2e0816ca59cff9a8b0eb238e1e5add7b943
Submitter: Zuul
Branch: master

commit 6e79c2e0816ca59cff9a8b0eb238e1e5add7b943
Author: Dmitry Galkin <email address hidden>
Date: Tue Aug 7 09:22:31 2018 +0000

    Worker should send NOTIFY also to all servers in 'also_notifies' pool settings.

    Change-Id: I0a85c5df5c323d6f636c8cb92ee5201c14cdb306
    Closes-Bug: #1785769

[Andreas Krebs (wintamute)]

I found this commited fix while searching for this 'also_notifies' issue. Looking at the changes I'm not sure how this actually fixes the issue since the fix lacks an actual implementation unless I'm missing something.

In https://git.openstack.org/cgit/openstack/designate/tree/designate/worker/service.py?id=6e79c2e0816ca59cff9a8b0eb238e1e5add7b943

class AlsoNotifyTask(object):
    """
    Placeholder to define options for also_notify targets
    """
    pass

[Dmitry Galkin (galkindmitrii)]

You're missing this method which creates notify tasks and appends them the task list for each entry in a particular pool.

    def _do_zone_action(self, context, zone):
        pool = self.get_pool(zone.pool_id)
        all_tasks = []
        all_tasks.append(zonetasks.ZoneAction(
            self.executor, context, pool, zone, zone.action
        ))

        # Send a NOTIFY to each also-notifies
        for also_notify in pool.also_notifies:
            notify_target = AlsoNotifyTask()
            notify_target.options = {'host': also_notify.host,
                                     'port': also_notify.port}
            all_tasks.append(zonetasks.SendNotify(self.executor,
                                                  zone,
                                                  notify_target))
        return self.executor.run(all_tasks)

[Andreas Krebs (wintamute)]

Yes, sorry for the noise, I was mainly missing a functioning brain after some hours of trouble shooting.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 8.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/720765

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/720766

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/720765
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=e4ee680f24d00b9633284c061edebaf0f62d7b3c
Submitter: Zuul
Branch: stable/rocky

commit e4ee680f24d00b9633284c061edebaf0f62d7b3c
Author: Dmitry Galkin <email address hidden>
Date: Tue Aug 7 09:22:31 2018 +0000

    Worker should send NOTIFY also to all servers in 'also_notifies' pool settings.

    Change-Id: I0a85c5df5c323d6f636c8cb92ee5201c14cdb306
    Closes-Bug: #1785769
    (cherry picked from commit 6e79c2e0816ca59cff9a8b0eb238e1e5add7b943)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/720766
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=076600dd9107baf567c3dc032a0901dfeda73784
Submitter: Zuul
Branch: stable/queens

commit 076600dd9107baf567c3dc032a0901dfeda73784
Author: Dmitry Galkin <email address hidden>
Date: Tue Aug 7 09:22:31 2018 +0000

    Worker should send NOTIFY also to all servers in 'also_notifies' pool settings.

    Change-Id: I0a85c5df5c323d6f636c8cb92ee5201c14cdb306
    Closes-Bug: #1785769
    (cherry picked from commit 6e79c2e0816ca59cff9a8b0eb238e1e5add7b943)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate rocky-eol release.