Infoblox driver get_dns_view error after changing multi_tenant option

[Erich Birngruber]

The Infoblox backend driver does a wrong comparison for the multi_tenant pool target option, when it was changed from "True" to "False":

see https://git.openstack.org/cgit/openstack/designate/tree/designate/backend/impl_infoblox/object_manipulator.py#n99

the problematic line:
if not self.connector.multi_tenant:

After changing this from True to False in the pools.yaml file and updating the pool info in the database, the value in the designate database is a VARCHAR '0'.

This does not work correctly for the "if not" comparison above, therefore it will always keep taking the wrong code path.

A fix would be to check for an empty value or the '0' value from the database:
if not self.connector.multi_tenant or self.connector.multi_tenant == '0':

Best,
Erich

[Russell Tweed (russell-tweed)]

Seems like the underlying issue is why that value's getting to set to VARCHAR '0' rather than something that actually parses as false.

However, adding the second comparison as per the description seems like it'd work for now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/550523

[Graham Hayes (grahamhayes)]

Yeah, I would suggest that the issue is in the YAML loading from the pools.yaml file.

We should still deal with the "0" as it may already be in peoples DB's, but fixing the designate-manage command's parsing is a better long term solution

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550523
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=e4de365775c1f6f2722f2ad3109f3349d9a5a691
Submitter: Zuul
Branch: master

commit e4de365775c1f6f2722f2ad3109f3349d9a5a691
Author: Russell Tweed <email address hidden>
Date: Wed Mar 7 16:30:36 2018 +0000

    Resolve get_dns_view error after selecting multi-tenant view

    Adds a second comparison check when deciding whether to display the single
    tenant view or multi-tenant view in Infoblox. The issue is that the DB field
    is set to '0', which is not interpreted as false.

    Change-Id: Id0fac71cc6d82123a7ee5d5983467acd1b8e5a9e
    Closes-Bug: 1752349

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/550634

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550634
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=fd5c3ccb6df50e4ab910da43b76b3424dac97d97
Submitter: Zuul
Branch: stable/queens

commit fd5c3ccb6df50e4ab910da43b76b3424dac97d97
Author: Russell Tweed <email address hidden>
Date: Wed Mar 7 16:30:36 2018 +0000

    Resolve get_dns_view error after selecting multi-tenant view

    Adds a second comparison check when deciding whether to display the single
    tenant view or multi-tenant view in Infoblox. The issue is that the DB field
    is set to '0', which is not interpreted as false.

    Change-Id: Id0fac71cc6d82123a7ee5d5983467acd1b8e5a9e
    Closes-Bug: 1752349
    (cherry picked from commit e4de365775c1f6f2722f2ad3109f3349d9a5a691)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 6.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 7.0.0.0b1 development milestone.