enable worker is deprecated but not start without enabling

Bug #1676827 reported by Eduardo Gonzalez
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Low
Unassigned

Bug Description

Using centos, source code from master.

Having worker enabled I'm having deprecation messages:

[service:worker]
enabled = True
notify = True

2017-03-28 11:35:25.754 5 WARNING oslo_reports.guru_meditation_report [-] Guru meditation now registers SIGUSR1 and SIGUSR2 by default for backward compatibility. SIGUSR1 will no longer be registered in a future release, so please use SIGUSR2 to generate reports.
2017-03-28 11:35:25.754 5 WARNING oslo_config.cfg [-] Option "enabled" from group "service:worker" is deprecated for removal. Its value may be silently ignored in the future.

If I remove enabled option, designate-worker service fails to start.

[service:worker]
notify = True

2017-03-28 11:31:15.832 5 ERROR designate.cmd.worker [-] You do not have designate-worker enabled, starting designate-worker is not allowed. You need to start designate-pool-manager instead.
2017-03-28 11:31:20.969 5 WARNING oslo_reports.guru_meditation_report [-] Guru meditation now registers SIGUSR1 and SIGUSR2 by default for backward compatibility. SIGUSR1 will no longer be registered in a future release, so please use SIGUSR2 to generate reports.
2017-03-28 11:31:20.970 5 ERROR designate.cmd.worker [-] You do not have designate-worker enabled, starting designate-worker is not allowed. You need to start designate-pool-manager instead.

Revision history for this message
Tim Simmons (timsim) wrote :

This is correct, the string is a little bit confusing, even though it's deprecated because we don't want to need this thing soon, it's still needed. Maybe update the string to be more clear?

Changed in designate:
status: New → Confirmed
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
Erik Olof Gunnar Andersson (eandersson) wrote :

This was fixed in Stein when the worker was enabled by default. It will however still log the deprecated warning if enabled is set in the configuration, but that is no longer required for the worker to function.

Changed in designate:
status: Confirmed → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.