Erroneous 'not found' logs in mdns on NOTIFYs

Bug #1671636 reported by Tim Simmons
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Erik Olof Gunnar Andersson

Bug Description

When Designate sends a NOTIFY, and gets a valid answer (NOERROR with no answer section),
we currently log a "zone not found on ip:port"

2017-03-09 19:17:43.086 6939 INFO designate.mdns.notify [req-a2b69cc0-9c1c-4f2f-a477-a3dc6512dbcc - - - - -] testdomain-1071707116.com. not found on 104.130.214.248:5322

This happens on seemingly every single NOTIFY.

This has no real effect, but it's a crazy confusing thing to have in the log.

It looks like it's because we have generalized code that catches this:
https://github.com/openstack/designate/blob/a7dda9c341506e295b6781860adf9b5dc5fc2102/designate/mdns/notify.py#L262-L264
You probably don't want that when you're querying the SOA record, obviously.

So that needs to be unwound a bit.

Tim Simmons (timsim)
Changed in designate:
status: New → Confirmed
importance: Undecided → High
tags: added: low-hanging-fruit
Revision history for this message
Pavan (pavan02) wrote :

Hi, I went through the code and I see that it logs for every attempt in sending DNS message(be it notify or SOA). Based on the description I assume that logs shouldn't happen for SOA. Am I correct?

If this is still a issue I would like to work on it.

Pavan (pavan02)
Changed in designate:
assignee: nobody → Pavan (pavan02)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/522915

Changed in designate:
status: Confirmed → In Progress
Changed in designate:
assignee: Pavan (pavan02) → nobody
status: In Progress → Triaged
Changed in designate:
assignee: nobody → Simon Leinen (simon-leinen)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/680567

Changed in designate:
assignee: Simon Leinen (simon-leinen) → Erik Olof Gunnar Andersson (eandersson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/680567
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=bcaf9fd149e36c437b65220de64a7a195301a337
Submitter: Zuul
Branch: master

commit bcaf9fd149e36c437b65220de64a7a195301a337
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Thu Sep 5 20:56:28 2019 -0700

    Only log zone not found when notifing

    We are currently logging zone not found when
    quering the SOA record. This should only
    happen when notifing.

    Change-Id: Iad790593a809a165718d3700cf7325f52208dab1
    Closes-Bug: #1671636

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 9.0.0.0rc1

This issue was fixed in the openstack/designate 9.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by "Dr. Jens Harbott <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/designate/+/522915

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.