nova/neutron format integration is failed

[Masaya Aoyama]

In the configuration file, we can use format parameter with designate-sink.
But "project" parameter can not use now.
   ex) #formatv4 = '%(hostname)s.%(project)s.%(domain)s'

https://github.com/openstack/designate/blob/master/designate/notification_handler/nova.py#L68

In the source file, use "getattr", but it doesn't work (context is dict object).
And "tenant" key is undefined from notification data.

For example...
-------------------------
{
    "auth_token": "45f7a05107d043e6ab31b968c7272abe",
    "domain": "None",
    "instance_lock_checked": "False",
    "is_admin": "True",
    "is_admin_project": "True",
    "project_domain": "None",
    "project_id": "ee3dce5c65df4e2ea6661e5f88a1e268",
    "project_name": "demo",
    "quota_class": "None",
    "read_deleted": "no",
    "read_only": "False",
    "remote_address": "172.17.125.160",
    "request_id": "req-f5d86fa3-ff33-46b7-b10b-af576520ee11",
    "resource_uuid": "None",
    "roles": [
        "admin"
    ],
    "service_catalog": [
        {
            "endpoints": [
                {
                    "adminURL": "http://172.17.125.160:8776/v1/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "internalURL": "http://172.17.125.160:8776/v1/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "publicURL": "http://172.17.125.160:8776/v1/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "region": "RegionOne"
                }
            ],
            "name": "cinder",
            "type": "volume"
        },
        {
            "endpoints": [
                {
                    "adminURL": "http://172.17.125.160:8776/v2/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "internalURL": "http://172.17.125.160:8776/v2/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "publicURL": "http://172.17.125.160:8776/v2/ee3dce5c65df4e2ea6661e5f88a1e268",
                    "region": "RegionOne"
                }
            ],
            "name": "cinderv2",
            "type": "volumev2"
        }
    ],
    "show_deleted": "False",
    "tenant": "ee3dce5c65df4e2ea6661e5f88a1e268",
    "timestamp": "2017-01-11T09:38:17.431153",
    "user": "0b43a53f3d2e48fc9e9ae0e0ac9ec751",
    "user_domain": "None",
    "user_id": "0b43a53f3d2e48fc9e9ae0e0ac9ec751",
    "user_identity": "0b43a53f3d2e48fc9e9ae0e0ac9ec751 ee3dce5c65df4e2ea6661e5f88a1e268 - - -",
    "user_name": "admin"
}
-------------------------

So, I try to change

from
  payload['project'] = getattr(context, 'tenant', None)
to
  payload['project'] = context.get("project_name", None)

And neutron format integration has same issue.
https://github.com/openstack/designate/blob/master/designate/notification_handler/neutron.py#L73-L74

I can fix it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418813

[Adrien Cunin (adri2000)]

Unfortunately, it's not fix committed as the patch hasn't been merged yet.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418813
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b23cae7b7839af2d2ed38c06a126f1e2a869ddd3
Submitter: Jenkins
Branch: master

commit b23cae7b7839af2d2ed38c06a126f1e2a869ddd3
Author: MasayaAoyama <email address hidden>
Date: Wed Jan 11 19:00:15 2017 +0900

    nova/neutron format integration is failed

    Modify designate-sink formatv4/v6 parameter "project".
    "tenant" key is not contain at "context" variable,
    so I use "project_name" key.
    And "context" dict object cannot use getattr function.

    Change-Id: If485766a928bc2143b0b15afe99af38a6f927239
    Closes-Bug: #1655581

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/475768

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/475768
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=586db067579aa5828d03b566dc0a50d5a49235da
Submitter: Jenkins
Branch: stable/ocata

commit 586db067579aa5828d03b566dc0a50d5a49235da
Author: MasayaAoyama <email address hidden>
Date: Wed Jan 11 19:00:15 2017 +0900

    nova/neutron format integration is failed

    Modify designate-sink formatv4/v6 parameter "project".
    "tenant" key is not contain at "context" variable,
    so I use "project_name" key.
    And "context" dict object cannot use getattr function.

    Change-Id: If485766a928bc2143b0b15afe99af38a6f927239
    Closes-Bug: #1655581
    (cherry picked from commit b23cae7b7839af2d2ed38c06a126f1e2a869ddd3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate 5.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/designate ocata-eol release.