ipv6 binding is broken

[Emilien Macchi]

When ipv6 is configured to bind designate API, it fails to start the process:

2016-12-23 16:45:28.918 32021 ERROR designate.service [-] Invalid ip:port pair: ::1:9001
2016-12-23 16:45:28.918 32021 ERROR designate.service Traceback (most recent call last):
2016-12-23 16:45:28.918 32021 ERROR designate.service File "/usr/lib/python2.7/site-packages/designate/service.py", line 131, in _split_host_port
2016-12-23 16:45:28.918 32021 ERROR designate.service return host, int(port)
2016-12-23 16:45:28.918 32021 ERROR designate.service ValueError: invalid literal for int() with base 10: ':1:9001'
2016-12-23 16:45:28.918 32021 ERROR designate.service
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service [-] Error starting thread.
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service Traceback (most recent call last):
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service File "/usr/lib/python2.7/site-packages/oslo_service/service.py", line 722, in run_service
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service service.start()
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service File "/usr/lib/python2.7/site-packages/designate/api/service.py", line 42, in start
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service super(Service, self).start()
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service File "/usr/lib/python2.7/site-packages/designate/service.py", line 232, in start
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service addresses = self._get_listen_on_addresses(9001)
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service File "/usr/lib/python2.7/site-packages/designate/service.py", line 138, in _get_listen_on_addresses
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service return map(_split_host_port, set(self._service_config.listen))
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service File "/usr/lib/python2.7/site-packages/designate/service.py", line 131, in _split_host_port
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service return host, int(port)
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service ValueError: invalid literal for int() with base 10: ':1:9001'
2016-12-23 16:45:28.918 32021 ERROR oslo_service.service

http://logs.openstack.org/38/393738/7/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/78839c8/logs/designate/api.txt.gz#_2016-12-23_16_45_28_918

[Graham Hayes (grahamhayes)]

https://github.com/openstack/designate/blob/master/designate/service.py#L130 looks suspicious. :/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/422015

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422015
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=184544ec6c155578192f69edcb02d74799e6cbe0
Submitter: Jenkins
Branch: master

commit 184544ec6c155578192f69edcb02d74799e6cbe0
Author: Graham Hayes <email address hidden>
Date: Wed Jan 18 15:22:38 2017 +0000

    Use the oslo_utils address parser

    Ours did not understand IPv6

    Change-Id: I4c15909ed22c64fde4a64eb612d52ddcca247f43
    Fixes-Bug: #1653839

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/426621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426621
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b595890f980ae28ff1c6d18baf3c6febf5f11c48
Submitter: Jenkins
Branch: stable/newton

commit b595890f980ae28ff1c6d18baf3c6febf5f11c48
Author: Graham Hayes <email address hidden>
Date: Wed Jan 18 15:22:38 2017 +0000

    Use the oslo_utils address parser

    Ours did not understand IPv6

    Change-Id: I4c15909ed22c64fde4a64eb612d52ddcca247f43
    Fixes-Bug: #1653839
    (cherry picked from commit 184544ec6c155578192f69edcb02d74799e6cbe0)