designate context broken by oslo.context commit adding is_admin_project key

Bug #1603036 reported by David Moreau Simard
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Kiall Mac Innes

Bug Description

When testing designate against the master branch of oslo.context, I noticed the following stack trace from central log file:

ERROR oslo_messaging.rpc.server [-] Exception during message handling
ERROR oslo_messaging.rpc.server Traceback (most recent call last):
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 133, in _process_incoming
ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/designate/rpc.py", line 191, in dispatch
ERROR oslo_messaging.rpc.server return super(RPCDispatcher, self).dispatch(*args, **kwds)
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 150, in dispatch
ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 116, in _do_dispatch
ERROR oslo_messaging.rpc.server ctxt = self.serializer.deserialize_context(ctxt)
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/designate/rpc.py", line 175, in deserialize_context
ERROR oslo_messaging.rpc.server return designate.context.DesignateContext.from_dict(context)
ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/designate/context.py", line 107, in from_dict
ERROR oslo_messaging.rpc.server return cls(**values)
ERROR oslo_messaging.rpc.server TypeError: __init__() got an unexpected keyword argument 'is_admin_project'
ERROR oslo_messaging.rpc.server

Full logs: http://logs.openstack.org/60/337860/9/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/36a10a1/logs/designate/central.txt.gz#_2016-07-14_10_10_25_362

This seems to stem from a commit that has not been tagged in a release yet: https://github.com/openstack/oslo.context/commit/d3af1d06b4046c25c199bf1c389a9e440a634bc6

summary: - designate context broken by oslo.context patch adding is_admin_project
+ designate context broken by oslo.context commit adding is_admin_project
key
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342107

Changed in designate:
assignee: nobody → Kiall Mac Innes (kiall)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/342107
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=1687df2f7893f741af313946c3c581eaf49ddd86
Submitter: Jenkins
Branch: master

commit 1687df2f7893f741af313946c3c581eaf49ddd86
Author: Kiall Mac Innes <email address hidden>
Date: Thu Jul 14 11:56:01 2016 +0100

    Don't hardcode options we pass to oslo.context

    As oslo.context adds/removes options, we shouldn't have to update
    a hardcoded list on our side.

    Change-Id: I159d5587d15fa9889066339a97a6b505096f080b
    Closes-Bug: 1603036

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/350758

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/mitaka)

Reviewed: https://review.openstack.org/350758
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=cdd04f8deed533042c3322d3eeeda70840eb9d03
Submitter: Jenkins
Branch: stable/mitaka

commit cdd04f8deed533042c3322d3eeeda70840eb9d03
Author: Kiall Mac Innes <email address hidden>
Date: Thu Jul 14 11:56:01 2016 +0100

    Don't hardcode options we pass to oslo.context

    As oslo.context adds/removes options, we shouldn't have to update
    a hardcoded list on our side.

    Change-Id: I159d5587d15fa9889066339a97a6b505096f080b
    Closes-Bug: 1603036

tags: added: in-stable-mitaka
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 3.0.0.0b3

This issue was fixed in the openstack/designate 3.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 2.1.0

This issue was fixed in the openstack/designate 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.