DNSPython 1.13.0 breaks gate

Bug #1580571 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Graham Hayes

Bug Description

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-designate-python27-db/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "designate/tests/test_agent/test_backends/test_bind9.py", line 54, in test_update_zone
    zone = self._create_dnspy_zone('example.org')
  File "designate/tests/test_agent/test_backends/test_bind9.py", line 69, in _create_dnspy_zone
    return dns.zone.from_text(zone_text, check_origin=False)
  File "/home/jenkins/workspace/gate-designate-python27-db/.tox/py27/local/lib/python2.7/site-packages/dns/zone.py", line 966, in from_text
    check_origin=check_origin)
  File "/home/jenkins/workspace/gate-designate-python27-db/.tox/py27/local/lib/python2.7/site-packages/dns/zone.py", line 599, in __init__
    self.zone = zone_factory(origin, rdclass, relativize=relativize)
  File "/home/jenkins/workspace/gate-designate-python27-db/.tox/py27/local/lib/python2.7/site-packages/dns/zone.py", line 96, in __init__
    raise ValueError("origin parameter must be convertable to a "
ValueError: origin parameter must be convertable to a DNS name

Tags: breaks-gate
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/315006

Changed in designate:
assignee: nobody → Graham Hayes (grahamhayes)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/315038

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/315039

Revision history for this message
Graham Hayes (grahamhayes) wrote :

I looks like there is a change in how origin is being dealt with.

It is checking if it is a string type (which it should be) but things my be getting lost on the path from zone.from_text() to the Zone.__init__()

I am reproducing right now, and will file a bug upstream.

In the mean time - blocking 1.13.0 from our requirements is a good idea, as this may break people who are not using U-C for master, and our stable branches that are not using U-C.

Revision history for this message
Graham Hayes (grahamhayes) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (stable/liberty)

Change abandoned by Kiall Mac Innes (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/315039
Reason: Auto sync pulled this + approved

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (stable/mitaka)

Change abandoned by Kiall Mac Innes (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/315038
Reason: Auto sync pulled this + approved

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by Kiall Mac Innes (<email address hidden>) on branch: master
Review: https://review.openstack.org/315006
Reason: Auto sync pulled this + approved

Revision history for this message
Kiall Mac Innes (kiall) wrote :
Changed in designate:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.