Periodic Recovery attempts to create ERROR'd secondary zones

[Tim Simmons]

If you've got a secondary zone that failed to zone transfer, it goes to ERROR.

Then, when it's in ERROR-CREATE state, periodic recovery will come along and try to recover it. This is not ideal because recovery doesn't know about secondary zones, and ends up trying to create it, which will fail because the zone has no NS records.

As an example, with a BIND backend:

1. Create a secondary zone, with bogus masters/etc
2. The zone will go to error
3. Wait until the Periodic Recovery runs
4. You will see that the process attempts to create the zone. Which, in BIND will fail, because there are no NS records.

It will do this forever.

This is a bit sticky, but we could probably start by making recovery not create ERROR'd secondary zones. Although, at some point, you'd want that to to get created, and it could be a complete zone, but still be in ERROR.

This could be an argument for a "Terminal" ERROR state, something that Designate can ignore, except in very specific cases (like a secondary zone that's broken?). Or just more ERROR states in general.