The zone records quota are not enforced

Bug #1548331 reported by Eric Larson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Eric Larson

Bug Description

The zone records quota is not enforced when set in the config.

To reproduce:

 - enable the quotas extension
 - set the zone_records to a small value (ie 5)
 - create a zone and add > zone_records number of records
 - no error message is provided mentioning going over quota

In looking at the code, the zone records quota is never enforced, but the recordset quotas are enforced.

Changed in designate:
assignee: nobody → Eric Larson (eric-larson)
Changed in designate:
status: New → Triaged
importance: Undecided → Critical
milestone: none → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/284361

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/284361
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b89a05e5fcdefc1fd54c088f62f72cd980d90098
Submitter: Jenkins
Branch: master

commit b89a05e5fcdefc1fd54c088f62f72cd980d90098
Author: Eric Larson <email address hidden>
Date: Wed Feb 24 11:07:23 2016 -0600

    Ensure the zone records quota is enforced

    When creating a recordset, we only assert the recordset specific quota
    is respected, ignoring the zone record quota.

    This updates the code to enforce the records quota as well as excludes
    the managed records when calculating the quota. Also, the submitted
    records are taken into account when testing the quota. For example, if
    the total number is 10 and the limit is 11 (the total must be less
    than the quota), submitting an update to a recordset to lower the
    number of A records from 5 to 3 should be allowed.

    Closes-Bug: #1548331
    Change-Id: I26839eca1c4901c5b8dbe3db69044c4da889b7d8

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/287458

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b3

This issue was fixed in the openstack/designate 2.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/288096

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/kilo)

Reviewed: https://review.openstack.org/288096
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b479cb7a3c2062a721f136a511d8d2ab7c33ea2b
Submitter: Jenkins
Branch: stable/kilo

commit b479cb7a3c2062a721f136a511d8d2ab7c33ea2b
Author: Eric Larson <email address hidden>
Date: Thu Mar 3 14:04:42 2016 -0600

    Ensure the zone records quota is enforced

    When creating a recordset, we only assert the recordset specific quota
    is respected, ignoring the zone record quota.

    This updates the code to enforce the records quota as well as excludes
    the managed records when calculating the quota. Also, the submitted
    records are taken into account when testing the quota. For example, if
    the total number is 10 and the limit is 11 (the total must be less
    than the quota), submitting an update to a recordset to lower the
    number of A records from 5 to 3 should be allowed.

    Cherry-pick from review.openstack.org/284361/

    Closes-Bug: #1548331
    Change-Id: I26839eca1c4901c5b8dbe3db69044c4da889b7d8

tags: added: in-stable-kilo
tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/287458
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=7175d2b2a2b8c3caa7191e35b71bfabcb570e715
Submitter: Jenkins
Branch: stable/liberty

commit 7175d2b2a2b8c3caa7191e35b71bfabcb570e715
Author: Eric Larson <email address hidden>
Date: Wed Mar 2 15:36:20 2016 -0600

    Ensure the zone records quota is enforced

    When creating a recordset, we only assert the recordset specific quota
    is respected, ignoring the zone record quota.

    This updates the code to enforce the records quota as well as excludes
    the managed records when calculating the quota. Also, the submitted
    records are taken into account when testing the quota. For example, if
    the total number is 10 and the limit is 11 (the total must be less
    than the quota), submitting an update to a recordset to lower the
    number of A records from 5 to 3 should be allowed.

    Cherry-pick from review.openstack.org/284361/

    Closes-Bug: #1548331
    Change-Id: I26839eca1c4901c5b8dbe3db69044c4da889b7d8

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/designate 1.0.2

This issue was fixed in the openstack/designate 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/designate 1.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.