domain-create never succeed in NSD4

Bug #1537688 reported by akagisho
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Trevor McCasland

Bug Description

domain-create command never succeed when the backend is NSD4.

It seems that "self._command(command)" returns not "ok" but "ok\n".

Related code:
https://github.com/openstack/designate/blob/master/designate/backend/impl_nsd4.py#L68-L76

Designate version: 2.0.0.0b1
NSD version: 4.0.1

Tim Simmons (timsim)
Changed in designate:
status: New → Triaged
milestone: none → mitaka-3
importance: Undecided → Medium
Changed in designate:
assignee: nobody → Trevor McCasland (twm2016)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291379

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/291379
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=e3ce8e0e4b4ad4b8936e7955e689b63403d6c701
Submitter: Jenkins
Branch: master

commit e3ce8e0e4b4ad4b8936e7955e689b63403d6c701
Author: twm2016 <email address hidden>
Date: Thu Mar 10 13:26:31 2016 -0600

    Strip "\n" character from result

    domain-create command never succeed when the backend is NSD4.

    "self._command(command)" returns not "ok" but "ok\n".

    Result is now stripped of the "\n" character
    Closes-Bug: #1537688

    Change-Id: Iddd4f4abc1cdd116f8b7b1e50dcff134c6f2214b

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/designate 2.0.0.0rc1

This issue was fixed in the openstack/designate 2.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/296395

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/296395
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=cadfb1d7218b7361f2be308365a940eb5e9c23b1
Submitter: Jenkins
Branch: stable/liberty

commit cadfb1d7218b7361f2be308365a940eb5e9c23b1
Author: twm2016 <email address hidden>
Date: Thu Mar 10 13:26:31 2016 -0600

    Strip "\n" character from result

    domain-create command never succeed when the backend is NSD4.

    "self._command(command)" returns not "ok" but "ok\n".

    Result is now stripped of the "\n" character
    Closes-Bug: #1537688

    Change-Id: Iddd4f4abc1cdd116f8b7b1e50dcff134c6f2214b

tags: added: in-stable-liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.