Designate

More record validation is needed

Bug #1533402 reported by James Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Rahman Syed
Designate mitaka-3 "m3"

Bug Description

(1) spf and txt records can end in a trailing \

(2) MX record allowed -0 as priority

(3) SSHFP record allowed -0 as fp_type

Tim Simmons (timsim)
Changed in designate:
status: New → Confirmed
milestone: none → mitaka-3
importance: Undecided → High
Rahman Syed (rsyed)
Changed in designate:
assignee: nobody → Rahman Syed (rahman-syed-w)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272669

Changed in designate:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/272669
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=eb3fe8ab592004248001e21cfcb7b160fad9a72d
Submitter: Jenkins
Branch: master

commit eb3fe8ab592004248001e21cfcb7b160fad9a72d
Author: Rahman Syed <email address hidden>
Date: Tue Jan 26 11:38:05 2016 -0600

    Add validation for MX, TXT, and SSHFP records

    Added validation to ensure that TXT records cannot end
    with a '\' character. Also added validation to ensure
    that a signed zero (-0) cannot be used as an MX record
    priority or SSHFP record fptype.

    Change-Id: Id9bd12f42d7fb5fab9d7a352080f40eec3e9b6b7
    Closes-Bug: 1533402

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/276166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/276166
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=31d46c9ff356a56b7521b341ad2dea011917f416
Submitter: Jenkins
Branch: stable/liberty

commit 31d46c9ff356a56b7521b341ad2dea011917f416
Author: Rahman Syed <email address hidden>
Date: Tue Jan 26 11:38:05 2016 -0600

    Add validation for MX, TXT, and SSHFP records

    Added validation to ensure that TXT records cannot end
    with a '\' character. Also added validation to ensure
    that a signed zero (-0) cannot be used as an MX record
    priority or SSHFP record fptype.

    Change-Id: Id9bd12f42d7fb5fab9d7a352080f40eec3e9b6b7
    Closes-Bug: 1533402

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b3

This issue was fixed in the openstack/designate 2.0.0.0b3 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/designate 1.0.2

This issue was fixed in the openstack/designate 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/designate 1.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.