periodic_sync_seconds cannot be set to None (in order to sync everything)

Bug #1531294 reported by Paul Glass
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Federico Ceratto

Bug Description

To reproduce,
- set `periodic_sync_seconds = None` in the pool manager config
- restart the pool manager

You should see the following exception in the pool manager logs:

Traceback (most recent call last):
  File "/root/designate/.venv/bin/designate-pool-manager", line 10, in <module>
    sys.exit(main())
  File "/root/designate/designate/cmd/pool_manager.py", line 49, in main
    service.wait()
  File "/root/designate/designate/service.py", line 366, in wait
    _launcher.wait()
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_service/service.py", line 284, in wait
    status, signo = self._wait_for_exit_or_signal(ready_callback)
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_service/service.py", line 257, in _wait_for_exit_or_signal
    self.conf.log_opt_values(LOG, logging.DEBUG)
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2314, in log_opt_values
    _sanitize(opt, getattr(group_attr, opt_name)))
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2640, in __getattr__
    return self._conf._get(name, self._group)
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2357, in _get
    value = self._do_get(name, group, namespace)
  File "/root/designate/.venv/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2400, in _do_get
    % (opt.name, str(ve)))
ConfigFileValueError: Value for option periodic-sync-seconds is not valid: invalid literal for int() with base 10: 'None'

This is despite the help string that says you can set it to None to sync all zones: https://github.com/openstack/designate/blob/master/designate/pool_manager/__init__.py#L54-L56

Changed in designate:
assignee: nobody → Federico Ceratto (federico-ceratto)
Tim Simmons (timsim)
Changed in designate:
status: New → Triaged
importance: Undecided → Medium
milestone: none → mitaka-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264301

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/264301
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=8bb77ae26cd3c436ac6fb79aa4d5392f12b7038c
Submitter: Jenkins
Branch: master

commit 8bb77ae26cd3c436ac6fb79aa4d5392f12b7038c
Author: Federico Ceratto <email address hidden>
Date: Wed Jan 6 18:19:15 2016 +0000

    Update periodic-sync-seconds help

    Change-Id: I768c087bdaaa590c41fba7dfc003f767ec6fa143
    Closes-Bug: 1531294

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b2

This issue was fixed in the openstack/designate 2.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/270332

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/liberty)

Reviewed: https://review.openstack.org/270332
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=9692202a518825b36a9b0a24e519fef5b20a0bbe
Submitter: Jenkins
Branch: stable/liberty

commit 9692202a518825b36a9b0a24e519fef5b20a0bbe
Author: Federico Ceratto <email address hidden>
Date: Wed Jan 20 17:32:45 2016 +0000

    Update periodic-sync-seconds help

    Change-Id: I5b73c7746c528fcc566dbc78bde7d9566d26f068
    Closes-Bug: 1531294

tags: added: in-stable-liberty
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/designate 1.0.2

This issue was fixed in the openstack/designate 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/designate 1.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.