Pool Manager doesn't retry Creates/Deletes

Bug #1503350 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Tim Simmons

Bug Description

When a Create/Delete fails in the Pool Manager for any reason (rndc failure, unavailable pdns database, network split) on a target, the code does not retry, and immediately triggers an ERROR state.

```
         try:
            backend.create_domain(context, domain)

            return True
        except Exception:
            LOG.exception(_LE("Failed to create domain %(domain)s on target "
                              "%(target)s"),
                          {'domain': domain.name, 'target': target.id})
            return False
```

This is different behavior than an update, and should be the same, because many times, a Create/Delete will succeed on the second try.

Tim Simmons (timsim)
tags: added: liberty-rc-potential
Changed in designate:
assignee: nobody → Tim Simmons (tim-simmons-t)
status: New → In Progress
Tim Simmons (timsim)
Changed in designate:
importance: Undecided → High
Revision history for this message
Kiall Mac Innes (kiall) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/230767
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=94dfad359f021ac3a15b2f7900611cc8425827d3
Submitter: Jenkins
Branch: master

commit 94dfad359f021ac3a15b2f7900611cc8425827d3
Author: TimSimmons <email address hidden>
Date: Sat Oct 3 13:32:09 2015 -0500

    retry creates/deletes in the pool manager

    - The pool manager doesn't retry creates/deletes right away. If there's
    just a small net split, or the DNS server has some temporary failure, trying
    a second time will usually succeed. This should fix a lot of premature ERROR
    states

    Change-Id: Ib61110c4e460e93b8b5cfa8a9256151a5cabc43b
    closes-bug: #1503350

Changed in designate:
status: In Progress → Fix Committed
Changed in designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.