Incorrect error code for unathorized policy on all_tenants and edit_managed attributes

Bug #1486709 reported by Rudrajit Tapadar
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Hardik Parekh

Bug Description

When using the --all-tenants or --edit-managed attributes for a user who doesn't have the privileges to run those attributes, designate fails with a 500 error. This should be a Forbidden (403) error.

The api.middleware unit tests should be updated to take care of the negative cases as well.

Tim Simmons (timsim)
Changed in designate:
status: New → Triaged
importance: Undecided → High
milestone: none → liberty-3
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-3 → liberty-rc1
Changed in designate:
assignee: nobody → hardik (hardik-parekh047)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223062

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/223062
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=f51ce400348bb9f9cca2fa1490ffb7cebdfbddee
Submitter: Jenkins
Branch: master

commit f51ce400348bb9f9cca2fa1490ffb7cebdfbddee
Author: hardik <email address hidden>
Date: Mon Sep 14 15:59:07 2015 +0530

    Handling Forbidden Exception

    This patch adds forbidden exception for all_tenants
    and edit_managed attributes.

    Change-Id: I7a160abee99cc787f18593cba5c9e33485a85239
    Closes-Bug: #1486709

Changed in designate:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/224212

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/kilo)

Reviewed: https://review.openstack.org/224212
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=3b2e61a76468dda14afad07f5899863810e2adf4
Submitter: Jenkins
Branch: stable/kilo

commit 3b2e61a76468dda14afad07f5899863810e2adf4
Author: hardik <email address hidden>
Date: Mon Sep 14 15:59:07 2015 +0530

    Handling Forbidden Exception

    This patch adds forbidden exception for all_tenants
    and edit_managed attributes.

    Change-Id: I7a160abee99cc787f18593cba5c9e33485a85239
    Closes-Bug: #1486709
    (cherry picked from commit f51ce400348bb9f9cca2fa1490ffb7cebdfbddee)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.