Exception when over-quota on domains is very confusing

Bug #1463488 reported by Matt Fischer
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-designateclient
Fix Released
High
sonu

Bug Description

When someone tries to go over quota on domains the error message is very confusing. It implies that you didn't put an email address in the API call, you have to dig to find out you're really over quota. I'm not sure what the point of any of the non-quota stuff is in this error because "Over quota" should be the text here, not just something hidden.

(Pdb) print str(e)
Validation Error: u'email' is a required property

Failed validating 'required' in schema[u'properties'][u'email']:
    {u'$schema': u'http://json-schema.org/draft-03/hyper-schema',
     u'additionalProperties': False,
     u'description': u'Domain',
     u'id': u'domain',
     u'links': [{u'href': u'/domains/{id}', u'rel': u'self'},
                {u'href': u'/domains/{id}/records', u'rel': u'records'},
                {u'href': u'/domains/{id}/servers', u'rel': u'servers'},
                {u'href': u'/domains', u'rel': u'collection'}],
     u'properties': {u'created_at': {u'description': u'Date and time of domain creation',
                                     u'format': u'date-time',
                                     u'readonly': True,
                                     u'type': u'string'},
                     u'description': {u'description': u'Description for the Domain',
                                      u'maxLength': 160,
                                      u'type': [u'string', u'null']},
                     u'email': {u'description': u'Hostmaster email address',
                                u'format': u'email',
                                u'maxLength': 255,
                                u'required': True,
                                u'type': u'string'},
                     u'id': {u'description': u'Domain Identifier',
                             u'pattern': u'^([0-9a-fA-F]){8}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){4}-([0-9a-fA-F]){12}$',
                             u'readonly': True,
                             u'type': u'string'},
                     u'name': {u'description': u'Domain name',
                               u'format': u'domain-name',
                               u'maxLength': 255,
                               u'readonly': True,
                               u'required': True,
                               u'type': u'string'},
                     u'serial': {u'description': u'Serial Number',
                                 u'maximum': 4294967295,
                                 u'minimum': 1,
                                 u'readonly': True,
                                 u'type': u'integer'},
                     u'ttl': {u'description': u'Time to live',
                              u'maximum': 2147483647,
                              u'minimum': 0,
                              u'type': u'integer'},
                     u'updated_at': {u'description': u'Date and time of last domain update',
                                     u'format': u'date-time',
                                     u'readonly': True,
                                     u'type': [u'string', u'null']}},
     u'title': u'domain'}

On instance[u'email']:
    {u'code': 413,
     u'request_id': u'req-859b6ef8-e83f-45cb-beae-2559ad23f246',
     u'type': u'over_quota'}

Matt Fischer (mfisch)
summary: - error message when over-quota on domains is very confusing
+ Exception when over-quota on domains is very confusing
Kiall Mac Innes (kiall)
affects: designate → python-designateclient
Tim Simmons (timsim)
Changed in python-designateclient:
status: New → Triaged
importance: Undecided → High
Changed in python-designateclient:
assignee: nobody → Pradeep Kumar Singh (pradeep-singh-u)
status: Triaged → In Progress
Changed in python-designateclient:
status: In Progress → Triaged
assignee: Pradeep Kumar Singh (pradeep-singh-u) → nobody
sonu (sonu-bhumca11)
Changed in python-designateclient:
assignee: nobody → sonu (sonu-bhumca11)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-designateclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221610

Changed in python-designateclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-designateclient (master)

Reviewed: https://review.openstack.org/221610
Committed: https://git.openstack.org/cgit/openstack/python-designateclient/commit/?id=519c18f92ee7eb9878e14ff8a6d0d8308ddc3e20
Submitter: Jenkins
Branch: master

commit 519c18f92ee7eb9878e14ff8a6d0d8308ddc3e20
Author: sonu.kumar <email address hidden>
Date: Wed Sep 9 11:44:33 2015 +0530

    Meaningful Exception for over-quota on domains

    This patch makes meaningful exception to be thrown
    when over-quota on domains is found.

    Change-Id: I98c7e41bc14eb758f45bc4d35dd12c0bd98e1b2b
    Closes-Bug: #1463488

Changed in python-designateclient:
status: In Progress → Fix Committed
Changed in python-designateclient:
milestone: none → 1.5.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-designateclient 1.5.0

This issue was fixed in the openstack/python-designateclient 1.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.